Rewrite rust_builtin helpers in Rust

[brson]

There are a bunch of little one-off functions in rustrt that don't need to be. Some of these are using the exchange heap, blocking the completion of moving the exchange heap to Rust.

[olsonjeffery]

Ok, so I've got a tentative list of c++ functions that I need to rewrite in rust to resolve this issue. I just want to make sure I've got my approach worked out correctly:

• the c++ in src/rt that uses kernel->malloc() need to be rewritten in rust within core.
• Within those codefiles in core, we will be using the private::exchange_alloc functions where we would use kernel->malloc() previously, otherwise keep the logic the same.

Is that correct?

NOTE: this implies moving std::uv_ll into core (rust_uv.cpp does some mallocs). Or should core export an API to do direct mallocs/frees to the exchange heap?

[olsonjeffery]

also: wasn't sure if private::exchange_alloc is the right place for me to call? Don't know if that module is just germaine to the underlying c++ impl or if that's the interface behind which you'll finish the exchange heap in rust to resolve #4813. If I should be using somewhere else, please do tell.

[brson]

@olsonjeffery that sounds about right. if you need to access the allocator directly then private::exchange_alloc is what to use. Please don't move uv into core yet, as that's not something I want to do lightly - std can get at the exchange allocator via core::rt::rt_exchange_malloc, or my making private::exchange_alloc public.

[olsonjeffery]

OK cool. I have no problem using whatever is the public API in all
instances. Thanks for answering my questions.
On Feb 8, 2013 5:15 PM, "Brian Anderson" notifications@github.com wrote:

@olsonjeffery https://github.com/olsonjeffery that sounds about right.
if you need to access the allocator directly then private::exchange_allocis what to use. Please don't move uv into core yet, as that's not something
I want to do lightly - std can get at the exchange allocator via
core::rt::rt_exchange_malloc, or my making private::exchange_alloc public.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/4812#issuecomment-13323480..