Simplify attribute_groups
#140539
Open
Simplify attribute_groups
#140539
+56
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every slice of symbols has a single entry. Let's just use a symbol directly.
There only needs to be one `Fn` per symbol, not multiple.
rustbot
added
A-attributes
|
Some changes occurred in compiler/rustc_attr_parsing |
jieyouxu
reviewed
May 1, 2025
Some are too long (> 100 chars), some are twoo short, some are missing full stops, some are missing upper-case letters at the start of sentences.
nnethercote
force-pushed
the
simplify-attribute_groups
branch
from
923fc5e to
e1ab116
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's more complicated than it needs to be.
r? @jdonszelmann