Skip to content

early return in trait detection for non-trait item #142191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2025
Merged

early return in trait detection for non-trait item #142191

merged 1 commit into from
Jun 9, 2025
+43 −18

Conversation

bvanjoi
Copy link
Contributor

@bvanjoi bvanjoi commented Jun 8, 2025 •
edited by rustbot
Loading

Fixes #135863

@rustbot
Copy link
Collaborator

rustbot commented Jun 8, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 8, 2025

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

compiler-errors
compiler-errors approved these changes Jun 8, 2025
View reviewed changes
@compiler-errors
Copy link
Member

r? compiler-errors @bors delegate+

@bors
Copy link
Collaborator

bors commented Jun 8, 2025

✌️ @bvanjoi, you can now approve this pull request!

If @compiler-errors told you to "r=me" after making some further change, please make that change, then do @bors r=@compiler-errors

@rustbot rustbot assigned compiler-errors and unassigned fee1-dead Jun 8, 2025
@bvanjoi
Copy link
Contributor Author

bvanjoi commented Jun 9, 2025

@bors r=@compiler-errors

@bors
Copy link
Collaborator

bors commented Jun 9, 2025

📌 Commit 7c1c566 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 9, 2025
Merged
bors added a commit that referenced this pull request Jun 9, 2025
@bors
Auto merge of #142234 - matthiaskrgr:rollup-kg5wibu, r=matthiaskrgr
7c10378 
Rollup of 6 pull requests

Successful merges:

 - #141751 (Remap compiler vs non-compiler sources differently (bootstrap side))
 - #142160 (Only allow `bootstrap` cfg in rustc & related)
 - #142191 (early return in trait detection for non-trait item)
 - #142211 (Do not checkout GCC submodule for the tidy job)
 - #142218 (CI: rfl: move job forward to Linux v6.16-rc1)
 - #142224 (Avoid a gratuitous 10s wait in a stress test)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9e25120 into rust-lang:master Jun 9, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 9, 2025
rust-timer added a commit that referenced this pull request Jun 9, 2025
@rust-timer
Unrolled build for #142191
be1ab9d 
Rollup merge of #142191 - bvanjoi:issue-135863, r=compiler-errors

early return in trait detection for non-trait item

Fixes #135863
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.

ICE: item_name: no name for DefPath
5 participants
@bvanjoi @rustbot @compiler-errors @bors @fee1-dead