[perf] Don't select on error path in probe #142203
Conversation
rustbot
added
the
T-compiler
|
@bors2 try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
[perf] Don't select on error path in probe
rustbot
added
the
S-waiting-on-perf
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (3aa0c80): comparison URL. Overall result: ❌ regressions - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -4.0%, secondary -4.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 751.361s -> 751.085s (-0.04%) |
rustbot
removed
the
S-waiting-on-perf
| @@ -287,6 +287,10 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> { | |||
| scope_expr_id: HirId, | |||
| candidate_filter: impl Fn(&ty::AssocItem) -> bool, | |||
| ) -> Vec<ty::AssocItem> { | |||
| if true { | |||
There was a problem hiding this comment.
oops this shouldnt have made it into the PR, but w/e.
No description provided.