A couple small changes for rust-analyzer next-solver work #145009
Merged
+16
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
rustbot
added
S-waiting-on-review
compiler-errors
approved these changes
Aug 6, 2025
|
r=me after fixing the merge conflict |
rust-cloud-vms
bot
force-pushed
the
ra-next-solver-changes
branch
from
e9b6d66 to
6296ca3
Compare
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
bot
force-pushed
the
ra-next-solver-changes
branch
from
6296ca3 to
a8f6528
Compare
|
@bors r=compiler-errors |
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 7, 2025
…=compiler-errors A couple small changes for rust-analyzer next-solver work Originally written by `@flodiebold`
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Aug 7, 2025
…=compiler-errors A couple small changes for rust-analyzer next-solver work Originally written by ``@flodiebold``
bors
added a commit
that referenced
this pull request
Aug 7, 2025
Rollup of 20 pull requests Successful merges: - #137831 (Tweak auto trait errors) - #143028 (emit `StorageLive` and schedule `StorageDead` for `let`-`else`'s bindings after matching) - #143764 (lower pattern bindings in the order they're written and base drop order on primary bindings' order) - #143808 (Port `#[should_panic]` to the new attribute parsing infrastructure ) - #143906 (Miri: non-deterministic floating point operations in `foreign_items`) - #143929 (Mark all deprecation lints in name resolution as deny-by-default and report-in-deps) - #144133 (Stabilize const TypeId::of) - #144439 (Introduce ModernIdent type to unify macro 2.0 hygiene handling) - #144473 (Address libunwind.a inconsistency issues in the bootstrap program) - #144659 (bootstrap: refactor mingw dist and fix gnullvm) - #144705 (compiler-builtins: plumb LSE support for aarch64 on linux/gnu when optimized-compiler-builtins not enabled) - #144807 (Streamline config in bootstrap) - #144900 (Stabilize `unsigned_signed_diff` feature) - #144903 (Rename `begin_panic_handler` to `panic_handler`) - #144931 ([win][arm64ec] Fix msvc-wholearchive for Arm64EC) - #144974 (compiler-builtins subtree update) - #144997 (bump bootstrap compiler to 1.90 beta) - #145004 (Couple of minor cleanups) - #145009 (A couple small changes for rust-analyzer next-solver work) - #145014 (Revert "Preserve the .debug_gdb_scripts section") r? `@ghost` `@rustbot` modify labels: rollup
lcnr
reviewed
Aug 7, 2025
| @@ -120,3 +123,19 @@ impl<CTX> HashStable<CTX> for InferConst { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| impl<I: Interner> TypeFoldable<I> for InferConst { | |||
There was a problem hiding this comment.
why does this have to be TypeFoldable instead of using #[type_foldable(identity)] and `#[type_visitable(ignore)]?
There was a problem hiding this comment.
IIRC I was just moving impls from other places in the compiler originally, maybe this got refactored afterwards
rust-cloud-vms
bot
force-pushed
the
ra-next-solver-changes
branch
from
a8f6528 to
0cb2c16
Compare
|
@bors r=compiler-errors |
rust-cloud-vms
bot
force-pushed
the
ra-next-solver-changes
branch
from
0cb2c16 to
29799c2
Compare
|
@bors r=compiler-errors |
bors
added a commit
that referenced
this pull request
Aug 8, 2025
Rollup of 19 pull requests Successful merges: - #144400 (`tests/ui/issues/`: The Issues Strike Back [3/N]) - #144764 ([codegen] assume the tag, not the relative discriminant) - #144807 (Streamline config in bootstrap) - #144899 (Print CGU reuse statistics in `-Zprint-mono-items`) - #144909 (Add new `test::print_merged_doctests_times` used by rustdoc to display more detailed time information) - #144912 (Resolver: introduce a conditionally mutable Resolver for (non-)speculative resolution.) - #144914 (Add support for `ty::Instance` path shortening in diagnostics) - #144931 ([win][arm64ec] Fix msvc-wholearchive for Arm64EC) - #144999 (coverage: Remove all unstable support for MC/DC instrumentation) - #145009 (A couple small changes for rust-analyzer next-solver work) - #145030 (GVN: Do not flatten derefs with ProjectionElem::Index. ) - #145042 (stdarch subtree update) - #145047 (move `type_check` out of `compute_regions`) - #145051 (Prevent name collisions with internal implementation details) - #145053 (Add a lot of NLL `known-bug` tests) - #145055 (Move metadata symbol export from exported_non_generic_symbols to exported_symbols) - #145057 (Clean up some resolved test regressions of const trait removals in std) - #145068 (Readd myself to review queue) - #145070 (Add minimal `armv7a-vex-v5` tier three target) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Aug 8, 2025
Rollup merge of #145009 - jackh726:ra-next-solver-changes, r=compiler-errors A couple small changes for rust-analyzer next-solver work Originally written by `@flodiebold`
lcnr
reviewed
Aug 8, 2025
| @@ -92,10 +92,15 @@ rustc_index::newtype_index! { | |||
|
|
|||
| /// An inference variable for a const, for use in const generics. | |||
| #[derive(Copy, Clone, Eq, PartialEq, PartialOrd, Ord, Hash)] | |||
| #[derive(TypeVisitable_Generic, TypeFoldable_Generic)] | |||
There was a problem hiding this comment.
wait... the same thing here, this should also be ignored by visitable impls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally written by @flodiebold