Skip to content

Not allow to use *-nominated for unauthorized users #145022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Kivooeo
Copy link
Contributor

@Kivooeo Kivooeo commented Aug 6, 2025

This change is techically reverting a 96cc0c6, this labels is uses by a team members after a meetings to nominate feature or changes, not see why we should allow this to unauthorized users. As you can see here #142204 (comment), I was able to successfully add a nominated label

r? @ChrisDenton

@rustbot
Copy link
Collaborator

rustbot commented Aug 6, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 6, 2025

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@Kivooeo Kivooeo changed the title Replace wildcard I-* pattern with explicit allowlist of I- labels Replace wildcard I-* pattern with explicit allowlist of I- labels Aug 6, 2025
@ChrisDenton
Copy link
Member

Sorry, I think you misunderstood me. I was surprised that the nominated labels were allowed to be set by unauthorised users but I think it is in fact intentional and hasn't caused any issues in practice.

@Kivooeo
Copy link
Contributor Author

Kivooeo commented Aug 6, 2025

Oh, if so then feel free to close, but overall I think it's not a bad addition

@Kivooeo
Copy link
Contributor Author

Kivooeo commented Aug 6, 2025

Hm, I guess we can ask @joshtriplett about this

I tracked a diff and it was not allowed back then

triagebot.toml Outdated
"I-slow",
"I-needs-decision",
"I-hang",
"I-prioritize",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T-compiler uses this mostly :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it in state it was before with "negative sytax"

@Kivooeo Kivooeo changed the title Replace wildcard I-* pattern with explicit allowlist of I- labels Not allow to use *-nominated for unauthorized users Aug 6, 2025
@traviscross
Copy link
Contributor

We allow and intend for all users to be able to change these nominated (and some other I-*) labels. There are indeed degrees to which we might expect most people to not interact with some of these, but in practice it hasn't been a problem. So until it is, or until we otherwise make a bigger project out of carefully delineating all these, it's probably safe to just close this.

@traviscross traviscross closed this Aug 6, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants