-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Not allow to use *-nominated
for unauthorized users
#145022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rustbot has assigned @Mark-Simulacrum. Use |
|
I-*
pattern with explicit allowlist of I- labelsI-*
pattern with explicit allowlist of I-
labels
Sorry, I think you misunderstood me. I was surprised that the nominated labels were allowed to be set by unauthorised users but I think it is in fact intentional and hasn't caused any issues in practice. |
Oh, if so then feel free to close, but overall I think it's not a bad addition |
Hm, I guess we can ask @joshtriplett about this I tracked a diff and it was not allowed back then |
triagebot.toml
Outdated
"I-slow", | ||
"I-needs-decision", | ||
"I-hang", | ||
"I-prioritize", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
T-compiler uses this mostly :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it in state it was before with "negative sytax"
I-*
pattern with explicit allowlist of I-
labels*-nominated
for unauthorized users
We allow and intend for all users to be able to change these nominated (and some other |
This change is techically reverting a 96cc0c6, this labels is uses by a team members after a meetings to nominate feature or changes, not see why we should allow this to unauthorized users. As you can see here #142204 (comment), I was able to successfully add a nominated label
r? @ChrisDenton