Implement fs api set_times and set_times_nofollow #147468

chenyukang · 2025-10-08T08:42:50Z

implementation of #147455

…tion for reusing it

rustbot · 2025-10-08T08:42:55Z

joshtriplett is not on the review rotation at the moment.
They may take a while to respond.

chenyukang · 2025-10-08T10:06:09Z

i'm following this PR: https://github.com/rust-lang/rust/pull/142938/files
somehow surprised we don't need to add unit test for a new api?

library/std/src/sys/fs/solid.rs

library/std/src/sys/fs/unix.rs

library/std/src/fs.rs

library/std/src/sys/fs/wasi.rs

chenyukang · 2025-10-16T12:00:06Z

@rustbot ready

joshtriplett · 2025-10-17T01:56:41Z

@bors r+ rollup

bors · 2025-10-17T01:56:44Z

📌 Commit 8182085 has been approved by joshtriplett

It is now in the queue for this repository.

…=joshtriplett Implement fs api set_times and set_times_nofollow implementation of rust-lang#147455 r? `@joshtriplett`

Rollup of 6 pull requests Successful merges: - #144936 (CFI: Fix types that implement Fn, FnMut, or FnOnce) - #147468 (Implement fs api set_times and set_times_nofollow) - #147660 (rustdoc-search: stringdex 0.0.2) - #147735 (Micro-optimization in `FunctionCx::initialize_locals`) - #147764 (Undo CopyForDeref assertion in const qualif) - #147783 (bootstrap: migrate to object 0.37) r? `@ghost` `@rustbot` modify labels: rollup

…=joshtriplett Implement fs api set_times and set_times_nofollow implementation of rust-lang#147455 r? ``@joshtriplett``

…=joshtriplett Implement fs api set_times and set_times_nofollow implementation of rust-lang#147455 r? ```@joshtriplett```

Rollup of 7 pull requests Successful merges: - #140153 (Implement `Debug` for `EncodeWide`) - #147454 (Fix backtraces with `-C panic=abort` on qnx; emit unwind tables by default) - #147468 (Implement fs api set_times and set_times_nofollow) - #147494 (std::thread spawn: Docs: Link to Builder::spawn; Make same.) - #147783 (bootstrap: migrate to object 0.37) - #147792 (Fix autodiff incorrectly applying fat-lto to proc-macro crates ) - #147809 (rustdoc: Fix passes order so intra-doc links are collected after stripping passes) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 8 pull requests Successful merges: - #140153 (Implement `Debug` for `EncodeWide`) - #145724 (the `#[track_caller]` shim should not inherit `#[no_mangle]`) - #147258 (iter repeat: panic on last) - #147454 (Fix backtraces with `-C panic=abort` on qnx; emit unwind tables by default) - #147468 (Implement fs api set_times and set_times_nofollow) - #147764 (Undo CopyForDeref assertion in const qualif) - #147805 (use module_child index as disambiguator for external items) - #147824 (docs: update Motor OS target docs) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #147468 - chenyukang:yukang-api-set-times, r=joshtriplett Implement fs api set_times and set_times_nofollow implementation of #147455 r? ````@joshtriplett````

joshtriplett · 2025-10-18T15:40:01Z

@chenyukang Thanks for working on this!

motor: Add new `set_times` stubs Motor OS `std` support (rust-lang#147000) and `set_times`/`set_times_nofollow` (rust-lang#147468) were merged around the same time, so Motor OS is missing this API and currently fails to build. cc `@lasiotus`

Rollup merge of #147930 - thaliaarchi:motor-set-times, r=joboet motor: Add new `set_times` stubs Motor OS `std` support (#147000) and `set_times`/`set_times_nofollow` (#147468) were merged around the same time, so Motor OS is missing this API and currently fails to build. cc `@lasiotus`

…=joshtriplett Implement fs api set_times and set_times_nofollow implementation of rust-lang#147455 r? ````@joshtriplett````

motor: Add new `set_times` stubs Motor OS `std` support (rust-lang#147000) and `set_times`/`set_times_nofollow` (rust-lang#147468) were merged around the same time, so Motor OS is missing this API and currently fails to build. cc `@lasiotus`

Rollup of 8 pull requests Successful merges: - rust-lang/rust#140153 (Implement `Debug` for `EncodeWide`) - rust-lang/rust#145724 (the `#[track_caller]` shim should not inherit `#[no_mangle]`) - rust-lang/rust#147258 (iter repeat: panic on last) - rust-lang/rust#147454 (Fix backtraces with `-C panic=abort` on qnx; emit unwind tables by default) - rust-lang/rust#147468 (Implement fs api set_times and set_times_nofollow) - rust-lang/rust#147764 (Undo CopyForDeref assertion in const qualif) - rust-lang/rust#147805 (use module_child index as disambiguator for external items) - rust-lang/rust#147824 (docs: update Motor OS target docs) r? `@ghost` `@rustbot` modify labels: rollup

joshtriplett added 2 commits October 7, 2025 13:16

library: fs: Factor out a file_time_to_timespec function in prepara…

1e6b444

…tion for reusing it

library: fs: Factor out the Apple file time to attrlist code for reuse

1bf555c

rustbot assigned joshtriplett Oct 8, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 8, 2025

This comment has been minimized.

Sign in to view

chenyukang marked this pull request as draft October 8, 2025 09:12

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2025

chenyukang force-pushed the yukang-api-set-times branch from f1ab883 to 1440cfb Compare October 8, 2025 09:59

This comment has been minimized.

Sign in to view

chenyukang force-pushed the yukang-api-set-times branch 8 times, most recently from c135e31 to 20f1468 Compare October 8, 2025 16:25

chenyukang marked this pull request as ready for review October 8, 2025 17:28

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 8, 2025