Skip to content

Conversation

@saethlin
Copy link
Member

I ran into a test failure with the 32-bit windows test on #117192, one of the tests has been incorrectly passing (until my change!) because it is picking up the stack protector from another function. I've tried to prevent that happening again by adding CHECK-DAGs for the start and end of each function.

I've also done my best to correct the comments, some were based on the fact that we used to run these tests with unwinding panics, but LLVM doesn't add protectors to function with SEH funclets so it's must more straightforward for these tests to use -Cpanic=abort.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 11, 2025
@saethlin
Copy link
Member Author

@bors try jobs=i686-msvc-1,i686-msvc-2,x86_64-msvc-1,x86_64-msvc-2

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Nov 11, 2025
Set -Cpanic=abort in windows-msvc stack protector tests

try-job: i686-msvc-1
try-job: i686-msvc-2
try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Nov 12, 2025

💔 Test for 2c131d9 failed: CI. Failed jobs:

@saethlin saethlin force-pushed the windows-stack-protectors branch from 41c145e to 57630ae Compare November 12, 2025 00:22
@saethlin
Copy link
Member Author

@bors try jobs=i686-msvc-1,i686-msvc-2,x86_64-msvc-1,x86_64-msvc-2

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Nov 12, 2025
Set -Cpanic=abort in windows-msvc stack protector tests

try-job: i686-msvc-1
try-job: i686-msvc-2
try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@rust-bors
Copy link

rust-bors bot commented Nov 12, 2025

💔 Test for 4f07087 failed: CI. Failed jobs:

@rust-log-analyzer

This comment has been minimized.

@saethlin saethlin force-pushed the windows-stack-protectors branch from 57630ae to 2852654 Compare November 12, 2025 04:42
@saethlin
Copy link
Member Author

@bors try jobs=i686-msvc-1,i686-msvc-2,x86_64-msvc-1,x86_64-msvc-2

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Nov 12, 2025
Set -Cpanic=abort in windows-msvc stack protector tests

try-job: i686-msvc-1
try-job: i686-msvc-2
try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@rust-log-analyzer

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Nov 12, 2025

💔 Test for b651f78 failed: CI. Failed jobs:

@saethlin saethlin force-pushed the windows-stack-protectors branch from 2852654 to 5197856 Compare November 12, 2025 23:45
@saethlin
Copy link
Member Author

@bors try jobs=i686-msvc-1,i686-msvc-2,x86_64-msvc-1,x86_64-msvc-2

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Nov 12, 2025
Set -Cpanic=abort in windows-msvc stack protector tests

try-job: i686-msvc-1
try-job: i686-msvc-2
try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Nov 13, 2025

💔 Test for 730886e failed: CI. Failed jobs:

@saethlin
Copy link
Member Author

@bors try jobs=i686-msvc-1,i686-msvc-2,x86_64-msvc-1,x86_64-msvc-2

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Nov 13, 2025
Set -Cpanic=abort in windows-msvc stack protector tests

try-job: i686-msvc-1
try-job: i686-msvc-2
try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@rust-bors
Copy link

rust-bors bot commented Nov 13, 2025

☀️ Try build successful (CI)
Build commit: 656f997 (656f997dca95117bdd725db6239552897670cc6b, parent: 503dce33e2e2a5d2fe978b2723ab2a994cc27472)

@saethlin saethlin marked this pull request as ready for review November 13, 2025 21:51
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants