-
Notifications
You must be signed in to change notification settings - Fork 14k
refactor mingw-w64 self-contained detection #149178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@bors try jobs=dist-x86_64-windows-gnu |
This comment has been minimized.
This comment has been minimized.
refactor mingw-w64 self-contained detection try-job: dist-x86_64-windows-gnu
|
💔 Test for 430b82e failed: CI. Failed job:
|
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
|
@bors try jobs=dist-x86_64-mingw |
refactor mingw-w64 self-contained detection try-job: dist-x86_64-mingw
This comment has been minimized.
This comment has been minimized.
@petrochenkov |
Split out from #147536 (comment)
This change decouples
detect_self_contained_mingw()from the linker determined bylinker_and_flavor(), allowing for better control over the process.There should only one user observable change from this PR. Passing
-Clinker=<linker>when is absent from PATH, will result in an error regarding inability to find<linker>, unless-Clink-self-containedis also provided.Previously,
-Clinker=<linker>allowed to call any executable shipped with Rust, includingrust-objcopy,wasm-component-ld.r? @petrochenkov