Skip to content

Removed confusing diagnostics note for trait required for ? operator use #150570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Human9000-bit wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Removed confusing diagnostics note for trait required for ? operator use #150570

Human9000-bit wants to merge 2 commits into from
+3 −13

Conversation

@Human9000-bit
Copy link

@Human9000-bit Human9000-bit commented Jan 1, 2026

  • test: modified bad-question-mark-on-trait-objects to match expected behavior
  • removed confusing message from diagnostics

fixes #150527

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 1, 2026
@Human9000-bit Human9000-bit marked this pull request as ready for review January 1, 2026 20:13
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 1, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 1, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 1, 2026

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jieyouxu jieyouxu

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Confusing diagnostic on ? operator: needs to implement Into<Error>

3 participants

@Human9000-bit @rustbot @jieyouxu