mir_build: Separate match lowering for string-equality and scalar-equality #150581
+110
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in match lowering cc @Nadrieril |
rustbot
added
S-waiting-on-review
Collaborator
|
|
Member
|
Looks good! I like how that clarifies the little hack around @bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jan 2, 2026
…uwer Rollup of 6 pull requests Successful merges: - #150425 (mapping an error from cmd.spawn() in npm::install) - #150444 (Expose kernel launch options as offload intrinsic args) - #150495 (Correct hexagon "unwinder_private_data_size") - #150578 (Fix a typo in the docs of AsMut for #149609) - #150581 (mir_build: Separate match lowering for string-equality and scalar-equality) - #150594 (Fix typo in the docs of `CString::from_vec_with_nul`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jan 2, 2026
Rollup merge of #150581 - Zalathar:string, r=Nadrieril mir_build: Separate match lowering for string-equality and scalar-equality - Follow-up to #150238 --- This PR takes some match-lowering code that is responsible for equality tests, and splits it into distinct code paths for string-equality and scalar-equality. The split results in more lines of code overall, but makes the separated code paths easier to understand individually. r? Nadrieril
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Jan 2, 2026
…uwer Rollup of 6 pull requests Successful merges: - rust-lang/rust#150425 (mapping an error from cmd.spawn() in npm::install) - rust-lang/rust#150444 (Expose kernel launch options as offload intrinsic args) - rust-lang/rust#150495 (Correct hexagon "unwinder_private_data_size") - rust-lang/rust#150578 (Fix a typo in the docs of AsMut for rust-lang/rust#149609) - rust-lang/rust#150581 (mir_build: Separate match lowering for string-equality and scalar-equality) - rust-lang/rust#150594 (Fix typo in the docs of `CString::from_vec_with_nul`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestableCase::Constantinto multiple sub-kinds #150238This PR takes some match-lowering code that is responsible for equality tests, and splits it into distinct code paths for string-equality and scalar-equality.
The split results in more lines of code overall, but makes the separated code paths easier to understand individually.
r? Nadrieril