Make --print=check-cfg output compatible --check-cfg arguments
#150840
+90
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
A-compiletest
Collaborator
|
r? @nnethercote rustbot has assigned @nnethercote. Use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes significantly the output of the unstable
--print=check-cfgoption.Specifically it removes the ad-hoc resemblance with
--print=cfgin order to output a simplified but still compatible--check-cfgarguments.The goal is to future proof the output of
--print=check-cfglike--check-cfgis, and the best way to do that is to use it's syntax.This is particularly relevant for RFC3905 which wants to introduce a new predicate:
version(...).