Skip to content

Avoid derive edits on macro-generated types - #162895

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
chenyukang:yukang-fix-148207-generated-derive-suggestion
Sep 18, 2026
Merged

rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
chenyukang:yukang-fix-148207-generated-derive-suggestion

Conversation

@chenyukang

@chenyukang chenyukang commented Sep 17, 2026 •

Copy link
Copy Markdown
Member

Fixes #148207

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 17, 2026
@rustbot

rustbot commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 77 candidates
  • Random selection from 20 candidates

@chenyukang chenyukang changed the title Avoid derive edits on macro-generated types @chenyukang Avoid derive edits on macro-generated types Sep 17, 2026
@petrochenkov

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@rust-bors

rust-bors Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 4a1b4b0 has been approved by petrochenkov

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 17, 2026
…ated-derive-suggestion, r=petrochenkov

Avoid derive edits on macro-generated types

Fixes rust-lang#148207
rust-bors Bot pushed a commit that referenced this pull request Sep 18, 2026
…uwer

Rollup of 10 pull requests

Successful merges:

 - #161987 (fix `is_single_fp_element` for `s390x` and `x86`)
 - #162366 (Replace hard linked `metadata.rmeta` with a copy when finalizing the incremental compilation session dir fails)
 - #162552 (RISC-V: Add Zmmul target feature)
 - #162602 (Ensure concurrent rustc instances in the same process correctly lock the session dir)
 - #162885 (Remove one remaining use of `Level::Help`)
 - #162606 (c-b: Export `fmaf16` now that we have an implementation)
 - #162817 (rustc_{codegen_,}llvm: adapt to new ThreadModel API)
 - #162860 (offload: add libLLVM rpath for libomptarget)
 - #162895 (Avoid derive edits on macro-generated types)
 - #162899 (Error on invalid placements of the `cfi_encoding` attribute.)
@rust-bors
rust-bors Bot merged commit f29e823 into rust-lang:main Sep 18, 2026
13 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 18, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 18, 2026
Rollup merge of #162895 - chenyukang:yukang-fix-148207-generated-derive-suggestion, r=petrochenkov

Avoid derive edits on macro-generated types

Fixes #148207
pull Bot pushed a commit to xtqqczze/rust-lang-rust-analyzer that referenced this pull request Sep 21, 2026
…uwer

Rollup of 10 pull requests

Successful merges:

 - rust-lang/rust#161987 (fix `is_single_fp_element` for `s390x` and `x86`)
 - rust-lang/rust#162366 (Replace hard linked `metadata.rmeta` with a copy when finalizing the incremental compilation session dir fails)
 - rust-lang/rust#162552 (RISC-V: Add Zmmul target feature)
 - rust-lang/rust#162602 (Ensure concurrent rustc instances in the same process correctly lock the session dir)
 - rust-lang/rust#162885 (Remove one remaining use of `Level::Help`)
 - rust-lang/rust#162606 (c-b: Export `fmaf16` now that we have an implementation)
 - rust-lang/rust#162817 (rustc_{codegen_,}llvm: adapt to new ThreadModel API)
 - rust-lang/rust#162860 (offload: add libLLVM rpath for libomptarget)
 - rust-lang/rust#162895 (Avoid derive edits on macro-generated types)
 - rust-lang/rust#162899 (Error on invalid placements of the `cfi_encoding` attribute.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rustc suggest a misleading place to add derive when using proc-macro

3 participants