std: Stabilize portions of `std::os::$platform` by alexcrichton · Pull Request #23353 · rust-lang/rust

alexcrichton · 2015-03-14T00:40:25Z

This commit starts to organize the std::os::$platform modules and in the
process stabilizes some of the functionality contained within. The organization
of these modules will reflect the organization of the standard library itself
with extension traits for primitives in the same corresponding module.

The OS-specific modules will grow more functionality over time including
concrete types that are not extending functionality of other structures, and
these will either go into the closest module in std::os::$platform or they
will grow a new module in the hierarchy.

The following items are now stable:

os::{unix, windows}
unix::ffi
unix::ffi::OsStrExt
unix::ffi::OsStrExt::{from_bytes, as_bytes, to_cstring}
unix::ffi::OsString
unix::ffi::OsStringExt::{from_vec, into_vec}
unix::process
unix::process::CommandExt
unix::process::CommandExt::{uid, gid}
unix::process::ExitStatusExt
unix::process::ExitStatusExt::signal
unix::prelude
windows::ffi
windows::ffi::OsStringExt
windows::ffi::OsStringExt::from_wide
windows::ffi::OsStrExt
windows::ffi::OsStrExt::encode_wide
windows::prelude

The following items remain unstable:

unix::io
unix::io::{Fd, AsRawFd}
unix::fs::{PermissionsExt, OpenOptionsExt}
windows::io
windows::io::{Handle, AsRawHandle}
windows::io::{Socket, AsRawSocket}
windows::fs
windows::fs::OpenOptionsExt

Due to the reorgnization of the platform extension modules, this commit is a
breaking change. Most imports can be fixed by adding the relevant libstd module
in the use path (such as ffi or fs).

[breaking-change]

rust-highfive · 2015-03-14T00:40:29Z

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton · 2015-03-14T00:40:58Z

r? @aturon

I'll also note that the whitespace-ignoring view for this PR may be more helpful

aturon · 2015-03-14T06:20:54Z

Exciting!

@bors: r+ 4c8d92b

Manishearth · 2015-03-14T10:24:12Z

@bors: p=2

OS-specific, let's get this merged earlier so it doesn't block/break the next rollup

bors · 2015-03-14T12:13:58Z

⌛ Testing commit 4c8d92b with merge 65ef39e...

bors · 2015-03-14T13:22:26Z

💔 Test failed - auto-mac-64-opt

Manishearth · 2015-03-14T13:24:37Z

/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt/build/src/libstd/os.rs:1708:17: 1708:34 error: unresolved import `os::unix::AsRawFd`. There is no `AsRawFd` in `sys::ext`
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt/build/src/libstd/os.rs:1708             use os::unix::AsRawFd;
                                                                                                     ^~~~~~~~~~~~~~~~~
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt/build/src/libstd/process.rs:576:13: 576:36 error: unresolved import `os::unix::ExitStatusExt`. There is no `ExitStatusExt` in `sys::ext`
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-opt/build/src/libstd/process.rs:576         use os::unix::ExitStatusExt;
                                                                                                     ^~~~~~~~~~~~~~~~~~~~~~~
error: aborting due to 2 previous errors
make: *** [x86_64-apple-darwin/stage2/test/stdtest-x86_64-apple-darwin] Error 101

alexcrichton · 2015-03-15T06:20:29Z

@bors: r=aturon

bors · 2015-03-15T06:20:30Z

~~@bors r=aturon e265e77~~

bors · 2015-03-15T08:16:57Z

⌛ Testing commit e265e77 with merge adc9d7b...

This commit starts to organize the `std::os::$platform` modules and in the process stabilizes some of the functionality contained within. The organization of these modules will reflect the organization of the standard library itself with extension traits for primitives in the same corresponding module. The OS-specific modules will grow more functionality over time including concrete types that are not extending functionality of other structures, and these will either go into the closest module in `std::os::$platform` or they will grow a new module in the hierarchy. The following items are now stable: * `os::{unix, windows}` * `unix::ffi` * `unix::ffi::OsStrExt` * `unix::ffi::OsStrExt::{from_bytes, as_bytes, to_cstring}` * `unix::ffi::OsString` * `unix::ffi::OsStringExt::{from_vec, into_vec}` * `unix::process` * `unix::process::CommandExt` * `unix::process::CommandExt::{uid, gid}` * `unix::process::ExitStatusExt` * `unix::process::ExitStatusExt::signal` * `unix::prelude` * `windows::ffi` * `windows::ffi::OsStringExt` * `windows::ffi::OsStringExt::from_wide` * `windows::ffi::OsStrExt` * `windows::ffi::OsStrExt::encode_wide` * `windows::prelude` The following items remain unstable: * `unix::io` * `unix::io::{Fd, AsRawFd}` * `unix::fs::{PermissionsExt, OpenOptionsExt}` * `windows::io` * `windows::io::{Handle, AsRawHandle}` * `windows::io::{Socket, AsRawSocket}` * `windows::fs` * `windows::fs::OpenOptionsExt` Due to the reorgnization of the platform extension modules, this commit is a breaking change. Most imports can be fixed by adding the relevant libstd module in the `use` path (such as `ffi` or `fs`). [breaking-change]

bors · 2015-03-15T09:18:41Z

💔 Test failed - auto-mac-64-opt

This commit starts to organize the `std::os::$platform` modules and in the process stabilizes some of the functionality contained within. The organization of these modules will reflect the organization of the standard library itself with extension traits for primitives in the same corresponding module. The OS-specific modules will grow more functionality over time including concrete types that are not extending functionality of other structures, and these will either go into the closest module in `std::os::$platform` or they will grow a new module in the hierarchy. The following items are now stable: * `os::{unix, windows}` * `unix::ffi` * `unix::ffi::OsStrExt` * `unix::ffi::OsStrExt::{from_bytes, as_bytes, to_cstring}` * `unix::ffi::OsString` * `unix::ffi::OsStringExt::{from_vec, into_vec}` * `unix::process` * `unix::process::CommandExt` * `unix::process::CommandExt::{uid, gid}` * `unix::process::ExitStatusExt` * `unix::process::ExitStatusExt::signal` * `unix::prelude` * `windows::ffi` * `windows::ffi::OsStringExt` * `windows::ffi::OsStringExt::from_wide` * `windows::ffi::OsStrExt` * `windows::ffi::OsStrExt::encode_wide` * `windows::prelude` The following items remain unstable: * `unix::io` * `unix::io::{Fd, AsRawFd}` * `unix::fs::{PermissionsExt, OpenOptionsExt}` * `windows::io` * `windows::io::{Handle, AsRawHandle}` * `windows::io::{Socket, AsRawSocket}` * `windows::fs` * `windows::fs::OpenOptionsExt` Due to the reorgnization of the platform extension modules, this commit is a breaking change. Most imports can be fixed by adding the relevant libstd module in the `use` path (such as `ffi` or `fs`). [breaking-change]

alexcrichton · 2015-03-15T17:28:57Z

@bors: r=aturon 1f5f76a

bors · 2015-03-15T18:42:55Z

⌛ Testing commit 1f5f76a with merge 542e2bb...

This commit starts to organize the `std::os::$platform` modules and in the process stabilizes some of the functionality contained within. The organization of these modules will reflect the organization of the standard library itself with extension traits for primitives in the same corresponding module. The OS-specific modules will grow more functionality over time including concrete types that are not extending functionality of other structures, and these will either go into the closest module in `std::os::$platform` or they will grow a new module in the hierarchy. The following items are now stable: * `os::{unix, windows}` * `unix::ffi` * `unix::ffi::OsStrExt` * `unix::ffi::OsStrExt::{from_bytes, as_bytes, to_cstring}` * `unix::ffi::OsString` * `unix::ffi::OsStringExt::{from_vec, into_vec}` * `unix::process` * `unix::process::CommandExt` * `unix::process::CommandExt::{uid, gid}` * `unix::process::ExitStatusExt` * `unix::process::ExitStatusExt::signal` * `unix::prelude` * `windows::ffi` * `windows::ffi::OsStringExt` * `windows::ffi::OsStringExt::from_wide` * `windows::ffi::OsStrExt` * `windows::ffi::OsStrExt::encode_wide` * `windows::prelude` The following items remain unstable: * `unix::io` * `unix::io::{Fd, AsRawFd}` * `unix::fs::{PermissionsExt, OpenOptionsExt}` * `windows::io` * `windows::io::{Handle, AsRawHandle}` * `windows::io::{Socket, AsRawSocket}` * `windows::fs` * `windows::fs::OpenOptionsExt` Due to the reorgnization of the platform extension modules, this commit is a breaking change. Most imports can be fixed by adding the relevant libstd module in the `use` path (such as `ffi` or `fs`). [breaking-change]

bors · 2015-03-15T21:16:02Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

rust-highfive assigned pcwalton Mar 14, 2015

rust-highfive assigned aturon and unassigned pcwalton Mar 14, 2015

huonw mentioned this pull request Mar 14, 2015

Tracking issue for RFC 517: IO reform #21070

Closed

10 tasks

aturon mentioned this pull request Mar 14, 2015

Stabilization for 1.0-beta #22500

Closed

91 tasks

alexcrichton force-pushed the stabilize-os branch from 4c8d92b to e265e77 Compare March 15, 2015 06:20

alexcrichton force-pushed the stabilize-os branch from e265e77 to 1f5f76a Compare March 15, 2015 17:28

bors merged commit 1f5f76a into rust-lang:master Mar 15, 2015

alexcrichton deleted the stabilize-os branch March 27, 2015 20:42

Uh oh!

Conversation

alexcrichton commented Mar 14, 2015

Uh oh!

rust-highfive commented Mar 14, 2015

Uh oh!

alexcrichton commented Mar 14, 2015

Uh oh!

aturon commented Mar 14, 2015

Uh oh!

Manishearth commented Mar 14, 2015

Uh oh!

bors commented Mar 14, 2015

Uh oh!

bors commented Mar 14, 2015

Uh oh!

Manishearth commented Mar 14, 2015

Uh oh!

alexcrichton commented Mar 15, 2015

Uh oh!

bors commented Mar 15, 2015

Uh oh!

bors commented Mar 15, 2015

Uh oh!

bors commented Mar 15, 2015

Uh oh!

alexcrichton commented Mar 15, 2015

Uh oh!

bors commented Mar 15, 2015

Uh oh!

bors commented Mar 15, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants