Skip to content

Make sure to run all clippy lints at warn level #2164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

blyxyas
Copy link
Member

@blyxyas blyxyas commented Jun 18, 2025

Previously running all the Clippy bench suite with the general command

cargo run --bin collector profile_local perf-record ~/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/bin/rustc --profiles Clippy --scenarios Full --exact-match ctfe-stress-5

This was because we were running deny-by-default lints and the collect is expecting everything to compile correctly.
Now rustc-perf sets every Clippy lint to warn to avoid that problem.

While it could be tempting to just open PRs to the respective failing crates to fix the issues, it's still healthy to run every single lint, even allow-by-defaults.


Note that if you run rustc-perf with a non-master Clippy, it will still fail because there are some unfiltered CTFE checks. These will be removed in the next release so they're not really a problem.

cc @Kobzol

Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please reformat and I'll approve it.

@blyxyas blyxyas force-pushed the run-all-clippy-lints branch from ee56d30 to 331680c Compare June 18, 2025 16:36
@blyxyas blyxyas force-pushed the run-all-clippy-lints branch from 331680c to 151803c Compare June 18, 2025 16:42
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@Kobzol Kobzol merged commit d7d0647 into rust-lang:master Jun 18, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants