Make sure to run all clippy lints at warn level #2164
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously running all the Clippy bench suite with the general command
This was because we were running deny-by-default lints and the collect is expecting everything to compile correctly.
Now rustc-perf sets every Clippy lint to
warn
to avoid that problem.While it could be tempting to just open PRs to the respective failing crates to fix the issues, it's still healthy to run every single lint, even allow-by-defaults.
Note that if you run rustc-perf with a non-
master
Clippy, it will still fail because there are some unfiltered CTFE checks. These will be removed in the next release so they're not really a problem.cc @Kobzol