Skip to content

Add nfc_normalize_idents flag - #6072

Open
Jules-Bertholet wants to merge 1 commit into
rust-lang:mainfrom
Jules-Bertholet:nfc-normalize-idents
Open

Jules-Bertholet wants to merge 1 commit into
rust-lang:mainfrom
Jules-Bertholet:nfc-normalize-idents

Conversation

@Jules-Bertholet

@Jules-Bertholet Jules-Bertholet commented Feb 13, 2024 •

Copy link
Copy Markdown
Contributor

Addresses #6058 @ytmimi

@ytmimi

ytmimi commented Feb 13, 2024

Copy link
Copy Markdown
Contributor

@Jules-Bertholet when you have a moment can you remove the fix for #6069 from this PR and open a separate PR that independently addresses that issue.

@Jules-Bertholet

Copy link
Copy Markdown
Contributor Author

The test for the nfc_normalize_idents relies on the #6069 fix to pass (it checks that NFC-normalizing idents in trait declaration works, which relies on rustfmt not immediately crashing in that situation.) So I can split it out, but this PR will then be blocked on that one.

@ytmimi

ytmimi commented Feb 13, 2024

Copy link
Copy Markdown
Contributor

The test for the nfc_normalize_idents relies on the #6069 fix to pass (it checks that NFC-normalizing idents in trait declaration works, which relies on rustfmt not immediately crashing in that situation.) So I can split it out, but this PR will then be blocked on that one.

Yeah, I'd rather split them out. The fix for #6069 will be easier to land, and then we can keep iterating on this new configuration.

@ytmimi ytmimi mentioned this pull request Feb 13, 2024
@jieyouxu jieyouxu added S-waiting-on-review Status: awaiting review from the assignee but also interested parties. and removed pr-not-reviewed labels Feb 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark: since after rust-lang/rust#149192 we also NFC-normalize lifetimes, so it would be good to either:

  • NFC-normalize lifetimes too, or
  • Add negative test coverage to show that this PR doesn't NFC-normalize lifetimes.

@rustbot

rustbot commented Mar 13, 2026

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (possibly #6823) made this pull request unmergeable. Please resolve the merge conflicts.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants