enable origin shield for docs.rs webserver #711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
syphar
force-pushed
the
docsrs-origin-shielt
branch
from
ddc1e6e to
cd8ae65
Compare
10 tasks
syphar
force-pushed
the
docsrs-origin-shielt
branch
2 times, most recently
from
113bbc5 to
58a07d6
Compare
marcoieni
approved these changes
Nov 27, 2025
Member
Author
|
note: let's try to test this first somehow |
Member
|
I tried to apply this but it's not compatible with wasm services. I asked clarification to fastly's support |
syphar
force-pushed
the
docsrs-origin-shielt
branch
2 times, most recently
from
0b5ee4e to
127cf0d
Compare
Member
Author
|
@marcoieni I updated the compute logic to what I think would the a correct approach. Right now the code is written very defensively, I want to see some logs when we play around with it. What do you think? Also about the logic? |
syphar
force-pushed
the
docsrs-origin-shielt
branch
from
127cf0d to
0ea4907
Compare
marcoieni
reviewed
Dec 2, 2025
marcoieni
reviewed
Dec 2, 2025
marcoieni
approved these changes
Dec 2, 2025
Member
marcoieni
left a comment
marcoieni
left a comment
There was a problem hiding this comment.
this makes sense to me. Let me know when you want to apply it 👍
Member
|
applied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would enable fastly origin shield for our webserver.
We have a huge number of pages that are accesed regularly, but not that often. Right now every POP manages its own cache, and also requests the origin on its own.
I hope this feature can help to improve cache ratio and offload more cachable requests from our server.
see also: