Skip to content

feat: port cleanup script to rust lang #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amustaque97 wants to merge 5 commits into
base: master
Choose a base branch
from
+281 −80
Open

feat: port cleanup script to rust lang #819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a2d8423
feat: port cleanup script to rust lang
amustaque97 Nov 22, 2025
24bb2a5
fix: fmt error
amustaque97 Nov 22, 2025
a6f8978
refactor: fix error
amustaque97 Nov 22, 2025
ef58d79
Update setup-deploy-keys/src/clean_unused_checkouts.rs
amustaque97 Nov 25, 2025
ff6e628
refactor: address review comment
amustaque97 Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 6 additions & 5 deletions ansible/roles/dev-desktop/tasks/cleanup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
---
- name: Copy cleanup script
template:
src: clean-unused-checkouts.sh
dest: /etc/cron.cleanup_disk_space

- name: Install clean-unused-checkouts binary
copy:
src: "{{ playbook_dir }}/../../../../setup-deploy-keys/target/release/clean-unused-checkouts"
Copy link

@Carbonhell Carbonhell Nov 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(disclaimer: I don't know much of Ansible) is the intended deployment strategy to compile the binary locally, with the target set based on the dev-desktop architecture/os? Would it make sense to add the compilation step as an Ansible task/playbook? Otherwise a simple note in the README would work as well

Copy link
Author

@amustaque97 amustaque97 Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me neither. Let's wait for the review from the team, and I will make the necessary changes.

dest: /usr/local/bin/clean-unused-checkouts
owner: root
group: root
mode: 0744
mode: 0755

- name: Set up the cleanup cron job
template:
Expand Down
74 changes: 0 additions & 74 deletions ansible/roles/dev-desktop/templates/clean-unused-checkouts.sh
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion ansible/roles/dev-desktop/templates/cron_cleanup_disk_space.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
PATH=/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin
0 0 * * * root /etc/cron.cleanup_disk_space
0 0 * * * root /usr/local/bin/clean-unused-checkouts
9 changes: 9 additions & 0 deletions setup-deploy-keys/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,19 @@ edition = "2021"
name = "deploy"
path = "src/deploy.rs"

[[bin]]
name = "clean-unused-checkouts"
path = "src/clean_unused_checkouts.rs"

[dependencies]
clap = { version = "4", features = ["derive", "env"] }
chrono = "0.4"
reqwest = { version = "0.11", features = ["blocking", "json"] }
serde = { version = "1.0", features = ["derive"] }
serde_json = "1.0"
base64 = "0.13"
walkdir = "2.4"

[dev-dependencies]
tempfile = "3.10"

Loading