Skip to content

Mark avx broadcast intrinsics as safe #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025

Conversation

okaneco
Copy link
Contributor

@okaneco okaneco commented Jun 23, 2025

The scalar functions are wrappers around _mm_set1_* functions which are already safe.

_mm256_broadcast_ps and _mm256_broadcast_pd take their input argument by reference instead of raw pointer.

@rustbot
Copy link
Collaborator

rustbot commented Jun 23, 2025

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@sayantn
Copy link
Contributor

sayantn commented Jun 26, 2025

The CI failure seems strange, could you force push it once to retry the CI? You can probably just do git commit --amend --allow-empty --no-edit && git push --force if the worktree is clean

@okaneco okaneco force-pushed the safe_broadcast branch 2 times, most recently from 54e82b5 to 799e76d Compare June 26, 2025 18:27
@okaneco
Copy link
Contributor Author

okaneco commented Jun 26, 2025

CI failed twice on Run ./ci/run-docker.sh armv7-unknown-linux-gnueabihf.

When I first submitted the PR, the failing x86_64-unknown-freebsd didn't seem to even start so it timed out.

@sayantn
Copy link
Contributor

sayantn commented Jun 27, 2025

The ARM failures bisect to rust-lang/rust#142768
I am not sure why the freebsd run didn't start, probably spurious since it didn't happen this time

@Amanieu Amanieu added this pull request to the merge queue Jul 7, 2025
Merged via the queue into rust-lang:master with commit eecb0f1 Jul 7, 2025
62 checks passed
@okaneco okaneco deleted the safe_broadcast branch July 7, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants