fix: issue 4865 Docker build failed #7072
Conversation
Signed-off-by: andreacfromtheapp <[email protected]>
|
Thank you! I will review this over the weekend :) |
|
I just realized you caught us on something - we updated our publishing process/commands on our internal publishing checklist, but forgot to update them here in the README (that's on me!) when we made some updates to the make files. This is the command we currently use to build the website rather than However, I think your changes to our Dockerfile will be very helpful. Testing things out now, then I will suggest some changes to the README on this pull request. |
There was a problem hiding this comment.
The Dockerfile works BEAUTIFULLY! I realized we hadn't updated our documentation, which explains some of the confusion, I've added suggestions to the README to reflect the make commands that we use (which do work with the new Dockerfile quite well). Thank you for catching this!
Co-authored-by: Nell Shamrell-Harrington <[email protected]>
Co-authored-by: Nell Shamrell-Harrington <[email protected]>
You are exactly right :) I couldn't catch that change and I'm glad that by chance it still worked fine! Happy to help. There would be more issues to amend IMHO but I'm unsure they would be welcome. Intersted in a discussion about them? |
|
Thanks for the updates! And I would welcome a discussion about more issues to amend. Feel free to send me an email [email protected] :) |
Hi @nellshamrell , I could reach out via email no problem, but I was wondering if enabling the Discussion feature on the repo would help for these kind of things. It has many advantages and history too. Let me know. |
these changes fix #4865 and close #7045