Skip to content

Static WebGL image. #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 19, 2021
Merged

Static WebGL image. #25

merged 11 commits into from
Jan 19, 2021

Conversation

Lokathor
Copy link
Member

@Lokathor Lokathor commented Jan 19, 2021

Part of #8

Doesn't do user interaction, that'll be a separate page.


TODO:

  • move the canvas into the body tag.
  • Fix the "can't use i64 note". Wasm is okay with i64, but the problem is that the FFI layer doesn't support it properly.

Copy link
Contributor

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good, the raw WASM approach wasn't nearly as arduous as I thought it'd be.


```html
<html>
<canvas width="800" height="600" id="my_canvas"></canvas>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The canvas should go in the body, ideally. Web browsers are fairly generous about what weird and wonderful HTML they'll accept, though, so it wouldn't surprise me if this still worked.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah, "it works on my machine", and that's just how it was in the example i followed.

But we can move it into the body.

@Lokathor Lokathor merged commit 10659cb into main Jan 19, 2021
@Lokathor Lokathor deleted the web branch January 19, 2021 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants