new arithmetic overflow rule #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for scrc-coding-guidelines ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
PLeVasseur
added
the
coding guideline
felix91gr
requested changes
Nov 26, 2025
Collaborator
felix91gr
left a comment
felix91gr
left a comment
There was a problem hiding this comment.
Preliminary review. We have a meeting together now, so I'd better submit it right away.
Contributor
Author
|
@felix91gr please approve me sir I am ready to be merged |
Contributor
Author
|
@felix91gr please review me. i'm very sad and wished to be merged. |
felix91gr
reviewed
Dec 4, 2025
Collaborator
|
@rcseacord there's a merge conflict. It seems to be pretty trivial from here, and Github offers to let me resolve it in the Web UI, but I'd rather you resolve them instead because I don't want to break your working copy |
fixed a bunch of small problems and started adding compliant solutions using saturation semantics
adding Wrapping<T> example
Revised guidelines on arithmetic overflow, emphasizing prevention and the use of explicit wrapping functions. Updated examples to reflect compliant practices with saturation semantics.
Co-authored-by: Félix Fischer <[email protected]>
Clarify guidelines on eliminating arithmetic overflow for various integer types.
Clarify behavior of arithmetic overflow in Rust.
rcseacord
force-pushed
the
feature/arithmetic-overflow
branch
from
aa88512 to
81e0d9e
Compare
Co-authored-by: Félix Fischer <[email protected]>
rcseacord
commented
Dec 4, 2025
Contributor
Author
|
@felix91gr rebased, please review! |
felix91gr
approved these changes
Dec 4, 2025
Collaborator
felix91gr
left a comment
felix91gr
left a comment
There was a problem hiding this comment.
This should be a reasonable first review, I hope
Clarified behavior of arithmetic overflow in debug and release modes. Updated examples to emphasize the use of explicit wrapping and saturation semantics.
Co-authored-by: Félix Fischer <[email protected]>
Co-authored-by: Félix Fischer <[email protected]>
Co-authored-by: Félix Fischer <[email protected]>
Co-authored-by: Félix Fischer <[email protected]>
Co-authored-by: Félix Fischer <[email protected]>
PLeVasseur
approved these changes
Dec 4, 2025
Collaborator
PLeVasseur
left a comment
PLeVasseur
left a comment
There was a problem hiding this comment.
LGTM, thanks @rcseacord
github-project-automation
bot
moved this to Done
in [Safety Critical Rust Consortium Coding Guidelines] Work Items
Collaborator
|
Reviewed in session 2025-12-03 |
manhatsu
pushed a commit
to manhatsu/safety-critical-rust-coding-guidelines
that referenced
this pull request
Dec 4, 2025
* new arithmetic overflow rule * Update expressions.rst fixed a bunch of small problems and started adding compliant solutions using saturation semantics * Update expressions.rst adding Wrapping<T> example * Revise arithmetic overflow guidelines and examples Revised guidelines on arithmetic overflow, emphasizing prevention and the use of explicit wrapping functions. Updated examples to reflect compliant practices with saturation semantics. * Update src/coding-guidelines/expressions.rst Co-authored-by: Félix Fischer <[email protected]> * Update expressions.rst to specify integer types for overflow Clarify guidelines on eliminating arithmetic overflow for various integer types. * Update guidelines on arithmetic overflow handling Clarify behavior of arithmetic overflow in Rust. * Clarify arithmetic overflow behavior in expressions.rst * rebase for fls errors * Update src/coding-guidelines/expressions.rst Co-authored-by: Félix Fischer <[email protected]> * Apply suggestion from @rcseacord * Clarify arithmetic overflow handling and examples Clarified behavior of arithmetic overflow in debug and release modes. Updated examples to emphasize the use of explicit wrapping and saturation semantics. * Update src/coding-guidelines/expressions.rst Co-authored-by: Félix Fischer <[email protected]> * Update src/coding-guidelines/expressions.rst Co-authored-by: Félix Fischer <[email protected]> * Update print statement format in Rust example * Update src/coding-guidelines/expressions.rst Co-authored-by: Félix Fischer <[email protected]> * Update src/coding-guidelines/expressions.rst Co-authored-by: Félix Fischer <[email protected]> * Update src/coding-guidelines/expressions.rst Co-authored-by: Félix Fischer <[email protected]> * Update expressions.rst --------- Co-authored-by: Félix Fischer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added new arithmetic overflow rule covers the following two CERT rules
INT30-C. Ensure that unsigned integer operations do not wrap
INT32-C. Ensure that operations on signed integers do not result in overflow