feat: add handler for unknown persona messages

[seer-by-sentry]

👋 Hi there! This PR was automatically generated by Autofix 🤖

This fix was triggered by Joe Becher

Fixes SERVER-CD

This change introduces a handler for unknown persona messages to prevent 'UNSUPPORTED_MESSAGECODE' errors. The handler logs the message and returns an empty response, allowing the server to continue processing.

If you have any questions or feedback for the Sentry team about this fix, please email [email protected] with the Run ID: 8233.

Summary by CodeRabbit

• Chores

  • Upgraded crash reporting and profiling dependencies for enhanced reliability.

• New Features

  • Introduced an improved mechanism for handling unrecognized messages, ensuring smoother and more stable operations.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes update dependency versions in multiple package configuration files by upgrading @sentry/node and @sentry/profiling-node from version 9.3.0 to 9.4.0. A new file is introduced in the persona package to handle unknown persona messages, and the internal message handling logic is updated by removing old comments and registering the new handler for op code 18245.

Changes

File(s)	Change Summary
package.json (root)	Updated dependency versions: @sentry/node from ^9.3.0 to ^9.4.0, @sentry/profiling-node from 9.3.0 to 9.4.0.
packages/cli/package.json, packages/nps/package.json, packages/persona/package.json, packages/shard/package.json, packages/shared-packets/package.json, packages/transactions/package.json, src/chat/package.json	Updated dependency version: @sentry/profiling-node from 9.3.0 to 9.4.0.
packages/persona/src/handlers/handleUnknownPersonaMessage.ts	New file added that exports an async function to process unknown persona messages by logging input and returning the connection details with an empty messages array.
packages/persona/src/internal.ts	Removed a large block of comments (licensing and description) and added an import for the new handler along with a new entry in the messageHandlers array for op code 18245.

Sequence Diagram(s)

sequenceDiagram
    participant Server
    participant Handler
    participant Logger

    Server->>Handler: Receive unknown persona message (opCode 18245)
    Handler->>Logger: Log operation code and message details
    Logger-->>Handler: Logging complete
    Handler-->>Server: Return { connectionId, messages: [] }

Loading

Poem

I'm a hopping rabbit with code to explore,
Upgrading Sentry - we're ready for more!
A new handler skips through each unknown chat,
Logs and responds, just like that.
In our code garden, every change makes me grin 🐰🥕!

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[deepsource-io]

Here's the code health analysis summary for commits 4a58d1b..07edcdb. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
JavaScript	❌ Failure	❗ 1 occurence introduced	View Check ↗

---

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

[codecov]

Codecov Report

Attention: Patch coverage is 35.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 46.37%. Comparing base (c12457d) to head (07edcdb).
Report is 139 commits behind head on capts-log-stardate-somewhere-sometime.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ersona/src/handlers/handleUnknownPersonaMessage.ts	7.14%	13 Missing ⚠️

❌ Your project check has failed because the head coverage (46.37%) is below the adjusted base coverage (46.39%). You can increase the head coverage or adjust the Removed Code Behavior.

Additional details and impacted files

@@                            Coverage Diff                            @@
##           capts-log-stardate-somewhere-sometime    #2507      +/-   ##
=========================================================================
- Coverage                                  46.39%   46.37%   -0.02%     
=========================================================================
  Files                                        205      206       +1     
  Lines                                      11452    11472      +20     
  Branches                                     722      722              
=========================================================================
+ Hits                                        5313     5320       +7     
- Misses                                      6138     6151      +13     
  Partials                                       1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[drazisil-codecov]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/persona/src/handlers/handleUnknownPersonaMessage.ts (1)

44-45: Consider adding metrics collection for unknown messages.

While logging unknown messages is helpful for debugging, consider adding metrics collection to track the frequency of unknown messages. This would help identify commonly occurring unknown messages that might need dedicated handlers.

-  log.debug(`Received unknown persona message: opCode=${message._header.id}`);
-  log.debug(`Message data: ${message._doSerialize().toString("hex")}`);
+  log.debug(`Received unknown persona message: opCode=${message._header.id}`);
+  log.debug(`Message data: ${message._doSerialize().toString("hex")}`);
+  
+  // If using Sentry, you could track this as a breadcrumb or custom event
+  try {
+    const Sentry = await import("@sentry/node");
+    Sentry.addBreadcrumb({
+      category: 'persona',
+      message: `Unknown persona message received with opCode=${message._header.id}`,
+      level: 'info'
+    });
+  } catch (e) {
+    // Silently continue if Sentry import fails
+  }

🧰 Tools

🪛 GitHub Check: codecov/patch

[warning] 43-45: packages/persona/src/handlers/handleUnknownPersonaMessage.ts#L43-L45
Added lines #L43 - L45 were not covered by tests

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4a58d1b and 07edcdb.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (10)

• package.json (1 hunks)
• packages/cli/package.json (1 hunks)
• packages/nps/package.json (1 hunks)
• packages/persona/package.json (1 hunks)
• packages/persona/src/handlers/handleUnknownPersonaMessage.ts (1 hunks)
• packages/persona/src/internal.ts (2 hunks)
• packages/shard/package.json (1 hunks)
• packages/shared-packets/package.json (1 hunks)
• packages/transactions/package.json (1 hunks)
• src/chat/package.json (1 hunks)

✅ Files skipped from review due to trivial changes (6)

• packages/shard/package.json
• packages/cli/package.json
• packages/shared-packets/package.json
• packages/transactions/package.json
• src/chat/package.json
• packages/persona/package.json

🧰 Additional context used

🪛 GitHub Check: codecov/patch

packages/persona/src/handlers/handleUnknownPersonaMessage.ts

[warning] 32-36: packages/persona/src/handlers/handleUnknownPersonaMessage.ts#L32-L36
Added lines #L32 - L36 were not covered by tests

---

[warning] 43-45: packages/persona/src/handlers/handleUnknownPersonaMessage.ts#L43-L45
Added lines #L43 - L45 were not covered by tests

---

[warning] 48-52: packages/persona/src/handlers/handleUnknownPersonaMessage.ts#L48-L52
Added lines #L48 - L52 were not covered by tests

🔇 Additional comments (5)

packages/nps/package.json (1)

21-21: Dependency version update to @sentry/profiling-node 9.4.0 looks good.

The package has been updated from the previous version (9.3.0) to 9.4.0, which is a minor version increment that likely includes bug fixes and performance improvements.

package.json (1)

41-42: Sentry dependencies update looks good.

Both Sentry packages have been updated to version 9.4.0, which keeps dependencies in sync across the project. This is a minor version update that likely includes bug fixes and improvements to error tracking and performance monitoring.

packages/persona/src/handlers/handleUnknownPersonaMessage.ts (1)

32-52:

❓ Verification inconclusive

Good implementation of fallback handler for unknown messages.

This handler provides a graceful way to deal with unknown message codes by logging them for debugging purposes and allowing the server to continue processing. This prevents 'UNSUPPORTED_MESSAGECODE' errors as intended.

However, this implementation has no test coverage as indicated by the static analysis tool.

Could we add unit tests to verify this handler works as expected? A simple test would verify:

1. The handler logs the message data
2. It returns an empty messages array with the connection ID

---

🏁 Script executed:

#!/bin/bash
# Check if there are any test files for this handler
fd "handleUnknownPersonaMessage.test" --type f --exec cat {}

Length of output: 62

---

Action: Add Unit Tests for Fallback Handler

This implementation gracefully handles unknown messages by logging details and returning an empty messages array. However, our verification shows there's currently no test coverage for this handler.

Could you add unit tests to cover the following?

• Verify that the handler logs the received message data.
• Confirm that the returned object contains the correct connection ID and an empty messages array.

🧰 Tools

🪛 GitHub Check: codecov/patch

[warning] 32-36: packages/persona/src/handlers/handleUnknownPersonaMessage.ts#L32-L36
Added lines #L32 - L36 were not covered by tests

---

[warning] 43-45: packages/persona/src/handlers/handleUnknownPersonaMessage.ts#L43-L45
Added lines #L43 - L45 were not covered by tests

---

[warning] 48-52: packages/persona/src/handlers/handleUnknownPersonaMessage.ts#L48-L52
Added lines #L48 - L52 were not covered by tests

packages/persona/src/internal.ts (2)

14-14: Import for new handler looks good.

The import statement is correctly added to bring in the new handler function.

---

74-78:

✅ Verification successful

Good integration of unknown message handler.

The new handler is correctly added to the messageHandlers array with the appropriate operation code (18245). The hexadecimal form (0x4745) is included in comments which helps with cross-referencing to client or protocol documentation.

Let's verify if there are any other occurrences of this op code in the codebase that might provide more context:

---

🏁 Script executed:

#!/bin/bash
# Search for the opcode in decimal or hex form
echo "Searching for opcode 18245 (0x4745) in the codebase..."
rg -i "18245|0x4745" --type ts --type js

Length of output: 221

---

Verified opcode usage in the repository.
The new handler for the unknown persona message is correctly integrated in packages/persona/src/internal.ts (lines 74-78) with the op code 18245 (noted as 0x4745 in the comment). A codebase search confirmed that this op code appears only in this location, indicating that the implementation is both isolated and correct.