fix(server): correct RSSI byte offset in frame parser (#332)#336
Merged
Conversation
) The server parsed rssi from buf[14] and noise_floor from buf[15], but the firmware (csi_collector.c) packs them at buf[16] and buf[17]: Firmware: n_subcarriers=u16(6-7) freq=u32(8-11) seq=u32(12-15) rssi=i8(16) Server: n_subcarriers=u8(6) freq=u16(8-9) seq=u32(10-13) rssi=i8(14) ← WRONG This caused RSSI to read the high byte of the sequence counter instead of the actual signed RSSI value, producing positive values (e.g., +9) instead of the correct negative values (e.g., -46 dBm). Added inline documentation of the frame layout matching csi_collector.c. Closes #332 Co-Authored-By: claude-flow <ruv@ruv.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes RSSI reading positive values (e.g., +9) instead of correct negative dBm (e.g., -46).
Root Cause
The firmware packs the CSI frame with
n_subcarriersasu16(2 bytes) andfreq_mhzasu32(4 bytes), but the server parser assumedu8andu16respectively — causing a 2-byte offset for RSSI and noise_floor.Test plan
cargo check— 0 errorsCloses #332
🤖 Generated with claude-flow