Fix benchmark environment lookup in ESM#1337
Open
Gujiassh wants to merge 1 commit intoruvnet:mainfrom
Open
Conversation
Use a real ESM-safe os import so benchmark suites can report environment metadata without crashing in pure module runtimes. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
require('os')call in the benchmark framework with an ESM-safenode:osimportrunAll()can collect environment info under the package's ESM test runtimeValidation
cd v3 && npx vitest run @claude-flow/performance/__tests__/benchmark.test.tslsp_diagnosticsclean onv3/@claude-flow/performance/src/framework/benchmark.tslsp_diagnosticsclean onv3/@claude-flow/performance/__tests__/benchmark.test.tsNotes
cd v3/@claude-flow/performance && npm run buildstill fails because of pre-existing@ruvector/attentionexport mismatches insrc/attention-benchmarks.ts/src/attention-integration.ts; this PR does not touch that existing build breakage