Skip to content

fix(main): guard app.on('activate') against firing before app.isReady() #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ruzin merged 1 commit into from
Jul 10, 2026
Merged

fix(main): guard app.on('activate') against firing before app.isReady() #326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions app/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1493,6 +1493,12 @@ if (!gotSingleInstanceLock) {
});

app.on('activate', () => {
// macOS can deliver 'activate' before Electron's own 'ready' event fires
// (e.g. cold launch via Dock). The whenReady().then() path below already
// creates the initial window once ready, so just no-op here until then -
// mirrors the same guard already used in the second-instance/open-url
// handlers above.
if (!app.isReady()) return;
rewarmParakeet('activate');
if (mainWindow) {
if (mainWindow.isMinimized()) mainWindow.restore();
Expand Down
Loading