Increase performance by changing requests to niquests

[NaruZosa]

From my end, I saw around a 10x increase in performance by patching pymsteams to use niquests instead of requests.
Niquests is a drop-in replacement for requests, but is actively maintained and runs faster with various improvements.

Also stops shadowing the built-in 'input' function

[rveachkc]

I really appreciate the work, but this seems to be a hot swap of niquests vs requests.

One of the reasons I have stayed with requests is that it is a library that can often be included with the os package manager.

I feel like the switch to niquests needs a bit more thought than I'm able to put into this right now.

[NaruZosa]

That's understandable.

Would you be willing to merge if it was a conditional import?
If Niquests exists, then it's used, otherwise Requests is used.

If not, I'm happy to fork if that would be preferable.

[rveachkc]

I would like to review niquests more to be honest. A conditional import could mitigate my concern, but it would also introduce a new layer of complexity. We already have that some with httpx. I see niquests as a potential to consolidate to a single http library. It does seem to be pure python, but I don't know the decency tree.

…

On Tue, Mar 18, 2025, 5:50 PM NaruZosa ***@***.***> wrote: That's understandable. Would you be willing to merge if it was a conditional import? If Niquests exists, then it's used, otherwise Requests is used. If not, I'm happy to fork if that would be preferable. — Reply to this email directly, view it on GitHub <#166 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABXLSLKZ6ZIPJJBLMD2NHTD2VCPNBAVCNFSM6AAAAABYB6F7TKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMZUHEYDINRVHE> . You are receiving this because you commented.Message ID: ***@***.***> [image: NaruZosa]*NaruZosa* left a comment (rveachkc/pymsteams#166) <#166 (comment)> That's understandable. Would you be willing to merge if it was a conditional import? If Niquests exists, then it's used, otherwise Requests is used. If not, I'm happy to fork if that would be preferable. — Reply to this email directly, view it on GitHub <#166 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABXLSLKZ6ZIPJJBLMD2NHTD2VCPNBAVCNFSM6AAAAABYB6F7TKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMZUHEYDINRVHE> . You are receiving this because you commented.Message ID: ***@***.***>

[NaruZosa]

The dependency tree for both are (taken from uv tree):

niquests v3.13.1 (latest):
├── charset-normalizer v3.4.1
├── urllib3-future v2.12.912
│   ├── h11 v0.14.0
│   ├── jh2 v5.0.8
│   └── qh3 v1.4.2
└── wassima v1.2.2 (certifi alternative that reads certs from OS Trust Store)

requests v2.32.3 (latest):
├── certifi v2024.8.30
├── charset-normalizer v3.4.1
├── idna v3.10
└── urllib3 v2.3.0