-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes tests clippy ci #18
Conversation
ac2d23a
to
9bf5b9d
Compare
Hey, @Fishrock123 , thank you very much for your PR. I'm definitely looking forward to make this crate more clean and adding supports to be able to use it in any future executors (tokio or async-std). So, here, the following constructs will have two different variants: AsyncRead
and possibly for Http primitives:
And these could be configured using build features. |
Also, as we develop any features and bug fixes in |
Should I re-target this PR? |
Yes, to the |
It's honestly quite confusing that the primary branch is not the development branch, btw. |
386faa9
to
1f64824
Compare
It's just a development pattern. We use |
This looks like it was for testing and seems like it probably was not intended to be checked in.
Similar to the ci.yml used in http-rs.
@rousan Hi, I'm considering using multer-rs in a rebase of http-rs/http-types#175 - i.e. multipart support for http-rs (Tide & Surf), hope these fixes are welcome!
(Along with this, I'm going to be looking at adding support here for
futures::io::AsyncRead
& friends as a build feature, and also possibly a build feature for using http-types instead of http.)