Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes tests clippy ci #18

Merged
merged 5 commits into from
Nov 5, 2020
Merged

Conversation

Fishrock123
Copy link
Contributor

@rousan Hi, I'm considering using multer-rs in a rebase of http-rs/http-types#175 - i.e. multipart support for http-rs (Tide & Surf), hope these fixes are welcome!

(Along with this, I'm going to be looking at adding support here for futures::io::AsyncRead & friends as a build feature, and also possibly a build feature for using http-types instead of http.)

@Fishrock123 Fishrock123 force-pushed the fixes-tests-clippy-ci branch from ac2d23a to 9bf5b9d Compare November 4, 2020 01:26
@rousan
Copy link
Member

rousan commented Nov 4, 2020

Hey, @Fishrock123 , thank you very much for your PR. I'm definitely looking forward to make this crate more clean and adding supports to be able to use it in any future executors (tokio or async-std).

So, here, the following constructs will have two different variants:

AsyncRead

  • from tokio::io::AsyncRead
  • from futures::io::AsyncRead

and possibly for Http primitives:

  • from http
  • from http-types

And these could be configured using build features.

@rousan
Copy link
Member

rousan commented Nov 4, 2020

Also, as we develop any features and bug fixes in develop branch, could you please send the PR to develop branch instead of master.

@Fishrock123
Copy link
Contributor Author

Should I re-target this PR?

@rousan
Copy link
Member

rousan commented Nov 4, 2020

Should I re-target this PR?

Yes, to the develop branch.

@Fishrock123 Fishrock123 changed the base branch from master to develop November 4, 2020 17:36
@Fishrock123
Copy link
Contributor Author

It's honestly quite confusing that the primary branch is not the development branch, btw.

@Fishrock123 Fishrock123 force-pushed the fixes-tests-clippy-ci branch 2 times, most recently from 386faa9 to 1f64824 Compare November 5, 2020 00:47
@rousan
Copy link
Member

rousan commented Nov 5, 2020

It's honestly quite confusing that the primary branch is not the development branch, btw.

It's just a development pattern. We use master branch for the latest stable code and develop for on-going unstable code.

@rousan rousan merged commit 42b589e into rwf2:develop Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants