Add 2D conv #5
Merged
Add 2D conv #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeoLegends
requested changes
Jul 14, 2025
There was a problem hiding this comment.
The memristor forward is hard to review for correctness, so I trust you on the correctness because it is difficult to get it to run and have bugs at the same time. Seems like the bit-exponent off by one error is fixed for all modules?
So the rest is LGTM!
Requested changes because test is not run, see comment.
| size = flat.shape[0] | ||
| positive_cells = CellArrayCPU(size) | ||
| negative_cells = CellArrayCPU(size) | ||
| for _ in range(num_cycles * 50): |
There was a problem hiding this comment.
ah the other modules have it as well.. why?
There was a problem hiding this comment.
In order to have cycles independent we needed a value larger than the internal cycle history of synaptogen.
We found it easier to not expose this to the outside, otherwise you have to set cycles always with a factor, which we deemed not so nice.
Co-authored-by: Moritz Gunz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.