Open
Conversation
Updated with more add-ons, all comments
Kroltez
commented
Apr 11, 2017
| //RGBLEDs : "fcb89c40c60359f37dc35ece444a401b", | ||
| //UIControlPoint : "fcb89c40c60459f37dc35ece444a401b", | ||
| //AutimationDigital : 2A56 //Bellow is a discriptor of this characteristic | ||
| NumDigitals : "2909" //Descriptor |
Author
There was a problem hiding this comment.
This is a Descriptor, not a Characteristic
|
Nice work. I am also following this project and it is great to see that it is getting contributions. Just general comment that it would be good idea to squash your 4 commits to one commit which will then result as a cleaner contribution and it is easier to review. Keep up good work :) |
Author
|
Ill upload the gatt.xml file from the THunedrboard with push access |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I named all the unknown characteristics you had with what they are. Source is SImplicerty Studio Main App GATT menu.