Skip to content

fix: encode parentheses in shareable links #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2025
Merged

fix: encode parentheses in shareable links #47

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b07987
fix: encode parentheses in shareable links
ryukinix Jul 13, 2025
7ffa21b
Update web/webapp.lisp
ryukinix Jul 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion web/webapp.lisp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,16 @@

(defmacro js-share-button-function ()
"

// encode parentheses as well to increase link-parsing compatibility in x.com and other platforms
function strictEncodeURIComponent(str) {
return encodeURIComponent(str)
.replaceAll('(', '%28')
.replaceAll(')', '%29');
}

var prop = document.getElementById('prop-input').value
var url = window.location.origin + window.location.pathname + '?prop=' + encodeURIComponent(prop);
var url = window.location.origin + window.location.pathname + '?prop=' + strictEncodeURIComponent(prop);
var shareUrlInput = document.getElementById('share-url');
shareUrlInput.value = url;
shareUrlInput.style.display = 'block';
Expand Down