Skip to content

fix(throughput): use fractional lookback divisor #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shikhar merged 1 commit into from
Feb 19, 2026
Merged

fix(throughput): use fractional lookback divisor #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/service/throughput.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ impl<const NUM_BUCKETS: usize> SlidingThroughput<NUM_BUCKETS> {
return 0.0;
}

let lookback_seconds_f64 = lookback.as_secs_f64().max(1.0);
let lookback_secs = lookback.as_secs().max(1);

let now_tick = self.now_secs();
Expand All @@ -76,7 +77,7 @@ impl<const NUM_BUCKETS: usize> SlidingThroughput<NUM_BUCKETS> {
idx = (idx + len - 1) % len;
}

sum as f64 / lookback_secs as f64
sum as f64 / lookback_seconds_f64
}

#[inline]
Expand Down Expand Up @@ -202,6 +203,15 @@ mod tests {
assert_close(t.bps(Duration::from_secs(1)), 1_000.0);
}

#[tokio::test(start_paused = true)]
async fn fractional_lookback_uses_fractional_divisor() {
let mut t = SlidingThroughput::<60>::default();
t.record(1_000);
tokio::time::advance(Duration::from_millis(1_500)).await;

assert_close(t.bps(Duration::from_millis(1_500)), 1_000.0 / 1.5);
}

#[tokio::test(start_paused = true)]
async fn excludes_current_partial_bucket() {
let mut t = SlidingThroughput::<60>::default();
Expand Down