Skip to content
This repository was archived by the owner on Feb 16, 2026. It is now read-only.

fix: rename S2_INSECURE to S2_SSL_NO_VERIFY#278

Merged
shikhar merged 1 commit intomainfrom
ssl_no_verify
Jan 27, 2026
Merged

fix: rename S2_INSECURE to S2_SSL_NO_VERIFY#278
shikhar merged 1 commit intomainfrom
ssl_no_verify

Conversation

@sgbalogh
Copy link
Member

... for the env var to disable SSL verification during tests.

Renamed to match s2-streamstore/s2-cli#210

@sgbalogh sgbalogh marked this pull request as ready for review January 27, 2026 00:48
@sgbalogh sgbalogh requested a review from a team as a code owner January 27, 2026 00:48
@greptile-apps
Copy link

greptile-apps bot commented Jan 27, 2026

Greptile Overview

Greptile Summary

Renamed the environment variable from S2_INSECURE to S2_SSL_NO_VERIFY to align with the s2-cli naming convention.

  • Updated the environment variable check in s2_config() function to use S2_SSL_NO_VERIFY instead of S2_INSECURE
  • The functionality remains unchanged - when the variable is set, SSL certificate verification is disabled during tests
  • No other occurrences of the old variable name found in the codebase

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • Simple variable rename with no functional changes, consistent across the codebase, and aligns with the naming convention used in the s2-cli project
  • No files require special attention

Important Files Changed

Filename Overview
tests/common/mod.rs Renamed environment variable from S2_INSECURE to S2_SSL_NO_VERIFY for consistency with s2-cli

Sequence Diagram

sequenceDiagram
    participant Test as Test Suite
    participant Config as s2_config()
    participant Env as Environment Variables
    participant S2Config as S2Config Builder
    
    Test->>Config: Call s2_config(compression)
    Config->>Env: Check S2_ACCESS_TOKEN
    Env-->>Config: Return access token
    Config->>S2Config: Create S2Config::new(token)
    
    Config->>Env: Check S2_ACCOUNT_ENDPOINT & S2_BASIN_ENDPOINT
    alt Endpoints set
        Env-->>Config: Return endpoint values
        Config->>S2Config: with_endpoints()
    end
    
    Config->>Env: Check S2_SSL_NO_VERIFY
    alt SSL verification disabled
        Env-->>Config: Variable is set
        Config->>S2Config: with_insecure_skip_cert_verification(true)
    end
    
    Config->>S2Config: with_compression(compression)
    S2Config-->>Config: Return configured S2Config
    Config-->>Test: Return S2Config
Loading

@shikhar shikhar merged commit a473eb9 into main Jan 27, 2026
6 checks passed
@shikhar shikhar deleted the ssl_no_verify branch January 27, 2026 00:57
@github-actions github-actions bot mentioned this pull request Jan 27, 2026
shikhar pushed a commit that referenced this pull request Jan 27, 2026
## 🤖 New release

* `s2-sdk`: 0.23.2 -> 0.23.3 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.23.3] - 2026-01-27

### Bug Fixes

- Explicitly enable git tagging and releases in release-plz
([#276](#276))
- Rename S2_INSECURE to S2_SSL_NO_VERIFY
([#278](#278))

<!-- generated by git-cliff -->
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants