feat!: add lower bounds for max_batch_bytes and max_batch_records

[quettabit]

addresses #251

[greptile-apps]

Greptile Overview

Greptile Summary

This PR adds lower bound validation to with_max_batch_bytes (minimum 8 bytes) and with_max_batch_records (minimum 1 record) methods in BatchingConfig. The changes prevent invalid configuration that could lead to runtime issues or undefined behavior.

Key changes:

• Introduced RECORD_BATCH_MIN constant using CountOrBytes type
• Added lower bound checks with clear error messages
• Improved error message consistency ("must not exceed" vs "exceeds")
• Updated documentation to reflect both lower and upper bounds
• Fixed existing test to comply with new 8-byte minimum requirement

Confidence Score: 5/5

• This PR is safe to merge with no issues found
• The changes are well-implemented with proper error handling, updated documentation, and adjusted tests. The validation logic is straightforward and prevents invalid configurations. The breaking change is justified and appropriately marked with the feat! prefix.
• No files require special attention

Important Files Changed

Filename	Overview
src/batching.rs	Added lower bound validation for batch configuration parameters with proper error messages and updated tests accordingly

Flowchart

flowchart TD
    A[User calls with_max_batch_bytes or with_max_batch_records] --> B{Check lower bound}
    B -->|Below minimum| C[Return ValidationError with lower bound message]
    B -->|Above or equal to minimum| D{Check upper bound}
    D -->|Exceeds maximum| E[Return ValidationError with upper bound message]
    D -->|Within bounds| F[Update config and return Ok]
    
    style C fill:#ff6b6b
    style E fill:#ff6b6b
    style F fill:#51cf66

Loading

_{Last reviewed commit: 7d465b3}