refactor!: make S2DateTime conversion from time::OffsetDateTime fallible

[quettabit]

No description provided.

[greptile-apps]

Greptile Summary

Changed S2DateTime conversion from time::OffsetDateTime to be fallible (using TryFrom instead of From), adding validation that the datetime can be formatted as RFC 3339. This prevents potential runtime panics from out-of-range years (outside -9999 to 9999).

• Implemented TryFrom<OffsetDateTime> for S2DateTime with RFC 3339 format validation
• Updated all conversion sites (AccessTokenInfo, StreamInfo in types.rs, and operations in ops.rs) to use fallible conversion with ? operator
• Updated test code to use try_into() instead of into()
• Made error messages consistent: "not a valid RFC 3339 datetime"

This is a breaking change that improves type safety by catching invalid datetimes at conversion time rather than during display/serialization.

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The refactoring is systematic and complete, properly converting all usage sites from infallible to fallible conversion. The validation logic is sound (RFC 3339 format validation), error handling is consistent, and the breaking change is appropriately marked with ! in the PR title
• No files require special attention

Important Files Changed

Filename	Overview
src/types.rs	Changed S2DateTime conversion from From to TryFrom with RFC3339 validation, updated dependent conversions in AccessTokenInfo and StreamInfo
src/ops.rs	Updated list_streams and create_stream to use try_into() for fallible StreamInfo conversion
tests/account_ops.rs	Updated test to use try_into() for S2DateTime conversion from OffsetDateTime

Flowchart

flowchart TD
    A[time::OffsetDateTime] -->|TryFrom::try_from| B{Validate RFC 3339}
    B -->|Can format| C[S2DateTime created]
    B -->|Cannot format| D[ValidationError]
    
    E[API Response] -->|parse| F[api::stream::StreamInfo]
    F -->|TryFrom| G{Convert created_at}
    G -->|Success| H{Convert deleted_at}
    G -->|Error| I[ValidationError]
    H -->|Success| J[StreamInfo]
    H -->|Error| I
    
    K[list_streams] -->|collect| L{Convert Vec of StreamInfo}
    L -->|All succeed| M[Page of StreamInfo]
    L -->|Any fails| N[S2Error]
    
    C -.->|Used in| G
    C -.->|Used in| H

Loading

_{Last reviewed commit: ac854d8}