Conversation
Greptile OverviewGreptile SummaryIntroduces separate retry configurations to prevent crashes during initial basin/stream creation in Antithesis environments with network faults.
The change correctly separates concerns: setup operations can tolerate long retry periods since they happen before the test begins, while test operations maintain the original retry behavior to ensure test accuracy. Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 992e7dd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use this repo internally within an Antithesis env, so network failures are expected. The actual log collection portion of this bin tolerates that (the errors become part of the log), but I found it was possible to crash during initial basin creation, before the actual test begins, if startup happens while network faults are occurring.