Feature/docker compose - #109
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces Docker Compose support for the PyiCub project, enabling containerized deployment with a separate YARP server service and improving configuration flexibility through environment variables.
Key Changes
- Added a new
compose.yarp.yamlfile to run YARP server as a separate containerized service - Renamed environment variables from
ICUBSRV_*toPYICUB_*for better naming consistency - Added conditional YARP server startup logic based on the
YARP_SERVERenvironment variable
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| docker/compose.yarp.yaml | New Docker Compose service definition for standalone YARP server with yarprun |
| docker/compose.yaml | Added include for yarp compose file, default image names, dependency on yarpserver service |
| docker/.env | Renamed ICUBSRV_* variables to PYICUB_*, added YARP_SERVER flag, changed default simulation mode to true |
| docker/Dockerfile.pyicub | Changed from git clone to COPY command for including repository code in the image |
| scripts/start.sh | Added conditional logic to either start or detect existing YARP server based on YARP_SERVER variable |
| scripts/common.sh | Renamed ICUBSRV_NODE to PYICUB_NODE in yarprun command, added check_existing_yarpserver function |
| icub-apps/applications/cluster-config.xml | Removed nameserver node attribute, renamed node from icubsrv-node to pyicub-node |
| icub-apps/applications/icubSim/icub-gazebo.xml | Replaced all references to ICUBSRV_NODE and ICUBSRV_HOST with PYICUB_NODE |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.