-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added select/deselect all notes button #1377
Open
Edgiest05
wants to merge
2
commits into
saber-notes:main
Choose a base branch
from
Edgiest05:feat-select-all
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same functionality is now available also in each directory of the browse page |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1377 +/- ##
==========================================
- Coverage 47.15% 47.01% -0.14%
==========================================
Files 114 115 +1
Lines 9002 9035 +33
==========================================
+ Hits 4245 4248 +3
- Misses 4757 4787 +30 ☔ View full report in Codecov by Sentry. |
620a0dc
to
56797dd
Compare
Resolved merge conflicts and updated |
56797dd
to
020b8af
Compare
020b8af
to
99080d2
Compare
99080d2
to
b8aa4b7
Compare
b8aa4b7
to
8f4eb6e
Compare
8f4eb6e
to
1a76d19
Compare
1a76d19
to
c8d9b91
Compare
c8d9b91
to
dbc6c69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced button in recent page footer that allows for selection of all notes
When less than all files are selected

When all files have already been selected, behaviour changes to unselect all

While implementing this I had to address that newer version of the
saver_gallery
dependency would not compile.Furthermore
preview_card
makes use of a different variableexpanded
when it actually should never differ from thewidget.selected
one (or else some selection changes do not reflect in the UI). I've kept it for consistency's sake.