Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Update Czech #1436

Merged
merged 3 commits into from
Apr 11, 2025
Merged

i18n: Update Czech #1436

merged 3 commits into from
Apr 11, 2025

Conversation

ceskyDJ
Copy link
Contributor

@ceskyDJ ceskyDJ commented Feb 23, 2025

No description provided.

Copy link

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.15%. Comparing base (df03da8) to head (3b3a3bf).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1436   +/-   ##
=======================================
  Coverage   47.15%   47.15%           
=======================================
  Files         114      114           
  Lines        9002     9002           
=======================================
  Hits         4245     4245           
  Misses       4757     4757           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ceskyDJ
Copy link
Contributor Author

ceskyDJ commented Feb 23, 2025

Hi, @adil192! It's a pretty long time since there was a last change in i18n!

I have some notes on this translation:

  • At first, I translated the description a bit differently, so it's a little more informative (at least from my point of view). Instead of your version, I used something like “Background template's lines thickness”. There is a little problem with the meaning of “line“ in Czech, so I used two forms to describe it more precisely (to add more context for the user).
  • The second note is about a preview. Line height (option just above this one) has a real-time preview, but there is nothing like that for line thickness. Could you please add it?

@adil192
Copy link
Member

adil192 commented Apr 11, 2025

The second note is about a preview. Line height (option just above this one) has a real-time preview, but there is nothing like that for line thickness. Could you please add it?

Tested now and the line thickness is updated in the real-time previews too. Maybe it was fixed since this PR was made

Copy link
Member

@adil192 adil192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adil192 adil192 merged commit f91de93 into saber-notes:main Apr 11, 2025
@ceskyDJ ceskyDJ deleted the update-czech branch April 11, 2025 16:24
@ceskyDJ
Copy link
Contributor Author

ceskyDJ commented Apr 11, 2025

The second note is about a preview. Line height (option just above this one) has a real-time preview, but there is nothing like that for line thickness. Could you please add it?

Tested now and the line thickness is updated in the real-time previews too. Maybe it was fixed since this PR was made

It still doesn't work for me. I have Saber v0.25.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants