Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Saving files in custom data dir not working on Android #1448

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ComputerElite
Copy link

This pull request fixes not being able to save or see certain notes when saving in a custom data directory by requesting the MANAGE_EXTERNAL_STORAGE permission when you select a custom data directory.

This way notes can be synced via Syncthing and more.

Closes #1223
Replaces #1442

Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 47.03%. Comparing base (7d60459) to head (917f42f).

Files with missing lines Patch % Lines
...mponents/settings/settings_directory_selector.dart 0.00% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1448      +/-   ##
==========================================
- Coverage   47.15%   47.03%   -0.13%     
==========================================
  Files         114      114              
  Lines        9002     9026      +24     
==========================================
  Hits         4245     4245              
- Misses       4757     4781      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saving files in custom data dir not working
1 participant