Skip to content

Conversation

zcysxy
Copy link
Contributor

@zcysxy zcysxy commented Jun 5, 2025

Added a parent <div> to the transclusion and included a link to the original file, matching the transclusion behavior of Quartz. This enables users to apply custom CSS and other customizations to the transclusion. I am not familiar with the naming conventions and slugification, so please modify as necessary.

@saberzero1
Copy link
Owner

Apologies for the delay.

I was wondering if this PR is still relevant. Currently, Quartz Syncer can be configured to either 'burn down' the embedded notes into the note with the embed links, or to not do that and let Quartz handle it, which produces the link icon similar to what this PR does.

The former option makes embedded notes appear as part of the note it is embedded in, even if the note that is embedded is not marked a publishable (this is intentional). The latter produces the same result as this change proposes, due to delegating the embedding to Quartz.

@zcysxy
Copy link
Contributor Author

zcysxy commented Jul 3, 2025

My original solution is not very elegant, so feel free to disregard this PR. I really like the idea of "burning down" the embeds from Quartz Syncer's end, because the user does not need to worry about whether the embedded note is published or not. However, I think it would be better to keep two options having the same style, i.e., some visual indication of the embed. Another advantage of using a consistent style is that CSS snippets targeting embeds will apply to both options. One use case is that I always hide the heading of the embedded section, which is only possible if the embed is wrapped in a special container.

@saberzero1
Copy link
Owner

saberzero1 commented Jul 3, 2025

My original solution is not very elegant, so feel free to disregard this PR. I really like the idea of "burning down" the embeds from Quartz Syncer's end, because the user does not need to worry about whether the embedded note is published or not. However, I think it would be better to keep two options having the same style, i.e., some visual indication of the embed. Another advantage of using a consistent style is that CSS snippets targeting embeds will apply to both options. One use case is that I always hide the heading of the embedded section, which is only possible if the embed is wrapped in a special container.

I mean, if you only embed a single section, you could use a block embed instead. Quartz Syncer burns these into the note as well. If you require multiple blocks under a section, I am more inclined to provide an option to hide the heading of a heading embed, similar to an option to ensure proper hierarchy. (E.g. embedding a h1 heading in a h3 section will change the h1 to a h3 to not break document flow.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants