fix(data-grid): persist cell updates when filtering is applied

[sadmann7]

Modified onDataUpdate in use-data-grid.ts to iterate over the complete dataset (currentData.length) instead of just filtered rows (tableRowCount). When filters were active, the function was building a partial data array containing only visible rows, causing onDataChange to miss updates for the complete dataset and preventing persistence to the database.

Fixes #1106

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
tablecn	Ready	Preview	Feb 24, 2026 10:51am

[Copilot]

Pull request overview

Fixes a persistence bug in useDataGrid where cell edits made while column filters are active were not being applied back onto the full underlying dataset, causing DB updates to miss unfiltered rows.

Changes:

• Update onDataUpdate to always rebuild newData using currentData.length (full dataset), not the filtered row count.
• Add tests ensuring edits while filtered are applied to the correct underlying row and onDataChange receives the full dataset.
• Update registry JSON snapshots to reflect onRowSelect using row.id (consistent with current source/types).

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File	Description
src/hooks/use-data-grid.ts	Fixes filtered-edit persistence by applying updates onto the full data array.
src/hooks/test/use-data-grid.test.tsx	Adds filter-aware edit tests and a simple filter function for the test columns.
public/r/data-grid-select-column.json	Registry snapshot updated to use row.id for selection callbacks.
public/r/data-grid-filter-menu.json	Registry snapshot updated to reflect onRowSelect signature using rowId.

Comments suppressed due to low confidence (3)

src/hooks/use-data-grid.ts:411

• if (!existingRow) treats valid falsy row values (e.g. 0, false, "") as missing and replaces them with {}. Since TData is unconstrained, prefer a nullish check (existingRow == null) and avoid synthesizing an empty object unless the data model explicitly guarantees object rows.

        if (!existingRow) {
          newData[i] = {} as TData;
          continue;
        }

src/hooks/use-data-grid.ts:406

• onDataUpdate rebuilds newData by looping over currentData.length on every edit. With large datasets (and especially during rapid edits/paste), this becomes O(n) per update even when only a few rows changed. Consider starting from a shallow copy of currentData and only cloning/applying changes for the indices present in rowUpdatesMap.

      const newData: TData[] = new Array(currentData.length);

      for (let i = 0; i < currentData.length; i++) {
        const updates = rowUpdatesMap.get(i);
        const existingRow = currentData[i];

src/hooks/test/use-data-grid.test.tsx:40

• In simpleFilterFn, the parameter is named _columnId but is used. Rename it to columnId (or similar) to avoid the conventional meaning of a leading underscore (intentionally unused).

const simpleFilterFn = (
  row: { getValue: (id: string) => unknown },
  _columnId: string,
  filterValue: string,
) => {
  const value = String(row.getValue(_columnId) ?? "");
  return value.toLowerCase().includes(filterValue.toLowerCase());

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.