fix(data-grid): exclude non-navigable columns during copying#1117
Merged
fix(data-grid): exclude non-navigable columns during copying#1117
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a clipboard data shifting issue where copying cells after selecting rows via checkbox included non-navigable columns ("select", "actions") in the TSV output, causing an empty leading column that shifted pasted values by one column.
Changes:
- Added filtering logic in
serializeCellsToTsvto skip non-navigable columns during the copy operation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
When copying cells after selecting rows via checkbox, the copy operation was including the "select" column (and other non-navigable columns) in the TSV output. This caused an empty leading column in the clipboard data, which then shifted all pasted values by one column when pasting. The fix: 1. Skips non-navigable columns (select, actions) during iteration in serializeCellsToTsv 2. Builds a navigableCells array as we iterate (more efficient than filtering afterward) 3. Returns navigableCells for accurate cell counts in toast messages and cutCells state Co-authored-by: Cursor <cursoragent@cursor.com>
sadmann7
force-pushed
the
sadman/fix-paste-checkbox-row-selection
branch
from
1876a6f to
32ce6b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When copying cells after selecting rows via checkbox, the copy operation was including the "select" column (and other non-navigable columns) in the TSV output. This caused an empty leading column in the clipboard data, which then shifted all pasted values by one column when pasting.
The fix filters out non-navigable columns (select, actions) in the serializeCellsToTsv function so they are not included in the copied TSV data.