-
-
Notifications
You must be signed in to change notification settings - Fork 674
Fix sage --docbuild -D #40588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Fix sage --docbuild -D #40588
Conversation
e452977
to
2596eb8
Compare
Documentation preview for this PR (built with commit c14a641; changes) is ready! 🎉 |
2596eb8
to
5ba5363
Compare
5ba5363
to
c8ed9a0
Compare
can you rather base this on #39030 ? |
then how can developers know what are available to build? |
@jhpalmieri I tried adding a test in https://github.com/sagemath/sage/compare/2596eb8fcab7312ab2454fce27386dec79f07f82..5ba53639c33bf9ce404d0d172d674c40389c6a88 but the meson builds already doesn't support this. I use meson editable build which still support this (and it works there), and am not too sure how the normal meson build works. (responding to #39973 (comment)) |
does the meson docbuild support this kind of granularity? Or it always builds everything in docs (that's my imperssion) |
I don't know actually, I just use the meson editable install which does support it.
that would be another undesirable breaking change. Building the whole PDF doc takes an hour, usually when you debug something you just want to build one module. |
isn't meson doing incremental rebuilds? It actually does not matter with incremental rebuilds tell the builder the module name, it's clever enough to know. yes, it comes with a slight disadvantage for a very seldom development process state when nothing is built, but you just want to check one particular file ... |
Hm, if they're separate meson build target then it ought to be able to specify the exact target to build on meson/ninja/whatever. Still, it ought to be documented somewhere so that developers such as us figure out how to use it. |
The command Also, the command |
address one of the issues raised in #40290 (comment) . this was originally broken in #39973
The new version did not work exactly as before either, now you need
en/
otherwise it wouldn't work, unlike what is explained in the manual. https://doc.sagemath.org/html/en/developer/sage_manuals.html#document-names📝 Checklist
⌛ Dependencies