Skip to content

remove deprecated (legacy) .discrete_log() method for elliptic-curve points #41007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

remove deprecated (legacy) .discrete_log() method for elliptic-curve points #41007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
488f0be
remove deprecated (legacy) .discrete_log() method for elliptic-curve …
yyyyx4 Oct 4, 2025
98b2014
adjust doctests
yyyyx4 Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions src/sage/schemes/elliptic_curves/ell_point.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4521,32 +4521,6 @@ def log(self, base):

return ZZ(pari.elllog(self.curve(), self, base, n))

def discrete_log(self, Q):
r"""
Legacy version of :meth:`log` with its arguments swapped.

Note that this method uses the opposite argument ordering
of all other logarithm methods in Sage; see :issue:`37150`.

EXAMPLES::

sage: E = EllipticCurve(j=GF(101)(5))
sage: P, = E.gens()
sage: (2*P).log(P)
2
sage: (2*P).discrete_log(P)
doctest:warning ...
DeprecationWarning: The syntax P.discrete_log(Q) ... Please update your code. ...
45
sage: P.discrete_log(2*P)
2
"""
from sage.misc.superseded import deprecation
deprecation(37150, 'The syntax P.discrete_log(Q) is being replaced by '
'Q.log(P) to make the argument ordering of logarithm'
' methods in Sage uniform. Please update your code.')
return Q.log(self)

def padic_elliptic_logarithm(self, Q, p):
r"""
Return the discrete logarithm of `Q` to base `P` = ``self``,
Expand Down
6 changes: 3 additions & 3 deletions src/sage/schemes/elliptic_curves/hom_velusqrt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,7 @@ def _point_outside_subgroup(P):
sage: P = E(4, 35)
sage: Q = _point_outside_subgroup(P); Q # random
(14 : 11 : 1)
sage: Q.curve()(P).discrete_log(Q)
sage: Q.log(P)
Traceback (most recent call last):
...
ValueError: ECDLog problem has no solution (...)
Expand All @@ -539,7 +539,7 @@ def _point_outside_subgroup(P):
True
sage: Q = _point_outside_subgroup(P); Q # random
(35*z2 + 7 : 24*z2 + 7 : 1)
sage: Q.curve()(P).discrete_log(Q)
sage: Q.log(Q.curve()(P))
Traceback (most recent call last):
...
ValueError: ECDLog problem has no solution (...)
Expand All @@ -554,7 +554,7 @@ def _point_outside_subgroup(P):
(18*z2 + 46 : 58*z2 + 61 : 1)
sage: Q in E
True
sage: P.discrete_log(Q)
sage: Q.log(P)
Traceback (most recent call last):
...
ValueError: ECDLog problem has no solution (...)
Expand Down
Loading