Skip to content

Fix an incorrect comparison in crypto/sbox #41017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix an incorrect comparison in crypto/sbox #41017

wants to merge 1 commit into from

Conversation

user202729
Copy link
Contributor

@user202729 user202729 commented Oct 9, 2025 •
edited
Loading

detected by the compiler

warning: self-comparison always evaluates to true [-Wtautological-compare]

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2025

Documentation preview for this PR (built with commit 85ff5ed; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yyyyx4 yyyyx4 yyyyx4 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

p: trivial / 5 s: positive review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@user202729 @yyyyx4