Skip to content

set full path to sage-num-threads.py in sage-env #41025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

set full path to sage-num-threads.py in sage-env #41025

wants to merge 2 commits into from
+1 −1

Conversation

dimpase
Copy link
Member

@dimpase dimpase commented Oct 10, 2025

fixes #40889
Apparently we no longer put SAGE_ROOT/src/bin/ in PATH

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@dimpase
set full path to sage-num-threads.py in sage-env
20f0c12 
fixes sagemath#40889
Apparently we no longer put SAGE_ROOT/src/bin/ in PATH
@dimpase dimpase mentioned this pull request Oct 10, 2025
Open
2 tasks
@dimpase dimpase requested a review from maxale October 10, 2025 17:56
maxale
maxale approved these changes Oct 10, 2025
View reviewed changes
Copy link
Contributor

@maxale maxale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It does the job!

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 10, 2025 •
edited
Loading

Documentation preview for this PR (built with commit 0e5602b; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

user202729
user202729 reviewed Oct 11, 2025
View reviewed changes
@user202729
Copy link
Contributor

just apply the diff above and test it on your machine. I suspect without it, the thing will break when the path to sage directory contains spaces.

@dimpase
Copy link
Member Author

dimpase commented Oct 11, 2025

OK, this works too.

@dimpase
Copy link
Member Author

dimpase commented Oct 11, 2025

just apply the diff above and test it on your machine. I suspect without it, the thing will break when the path to sage directory contains spaces.

thanks. I'm not sure we provide fully functioning sage with spaces in SAGEROOT, but ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@user202729 user202729 user202729 left review comments

@maxale maxale maxale approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

s: positive review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sage silently resets SAGE_NUM_THREADS environment variable

3 participants

@dimpase @user202729 @maxale