MERGE?! fix: message not showing up & view rendering timeout#8
Open
CedricBojoly wants to merge 3 commits into
Open
MERGE?! fix: message not showing up & view rendering timeout#8CedricBojoly wants to merge 3 commits into
CedricBojoly wants to merge 3 commits into
Conversation
…t to do this after rendering
Author
|
If you load the spinner it can also happen that the view is not rendered but the directive try to show the view. I fixed it with a setTimeout(fn, 0) |
CedricBojoly
changed the title
CedricBojoly
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the message will show up even if the spinner is loaded in constructor or in ngOnInit