Skip to content

fix(config): change LLM_BACKEND default from gpt-4o to openai #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sahoo-tech merged 2 commits into from
May 21, 2026
Merged

fix(config): change LLM_BACKEND default from gpt-4o to openai #178

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f61bc3
fix(config): change LLM_BACKEND default from gpt-4o to openai
Ridanshi May 17, 2026
32f6855
Merge branch 'main' into fix/llm-factory-default-backend
sahoo-tech May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion tests/unit/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def test_settings_correct_defaults():
settings = Settings()

# LLM Configuration
assert settings.LLM_BACKEND == "gpt-4o"
assert settings.LLM_BACKEND == "openai"
assert settings.OPENAI_API_KEY == ""
assert settings.GEMINI_API_KEY == ""

Expand Down Expand Up @@ -102,6 +102,20 @@ def test_settings_override_via_env_vars():
assert settings.TRUST_SCORE_W3 == 0.15


def test_default_llm_backend_resolves_in_factory():
"""Default LLM_BACKEND must match a supported factory branch (not raise ValueError)."""
from unittest.mock import patch
from core.config import Settings

settings = Settings()
backend = settings.LLM_BACKEND.lower()
supported = {"openai", "gemini", "llama"}
assert backend in supported, (
f"Default LLM_BACKEND '{backend}' is not handled by LLMClientFactory. "
f"Supported values: {supported}"
)


def test_settings_missing_required_key_raises_error():
"""Test that missing required API keys raise ValueError."""
from core.config import Settings
Expand Down
Loading