Skip to content

Remove deprecated UNSAFE_componentWillUpdate in SLDSDataTable #3053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove deprecated UNSAFE_componentWillUpdate in SLDSDataTable #3053

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9aae4b7
remove usage of UNSAFE_componentWillUpdate by replacing it with getSn…
DNiederweis Jun 27, 2022
2d2b0b4
Merge branch 'master' into fix-UNSAFE_componentWillUpdate-SLDSDataTable
DNiederweis Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions components/data-table/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,6 +499,13 @@ class DataTable extends React.Component {
return [];
}

getSnapshotBeforeUpdate(prevProps) {
if (prevProps.items !== this.props.items) {
this.interactiveElements = {};
}
return null;
}

getId() {
return this.props.id || this.generatedId;
}
Expand Down Expand Up @@ -690,13 +697,6 @@ class DataTable extends React.Component {
}
};

// eslint-disable-next-line camelcase
UNSAFE_componentWillUpdate(nextProps) {
if (this.props.items !== nextProps.items) {
this.interactiveElements = {};
}
}

isResizable() {
return this.props.fixedLayout && this.props.resizable;
}
Expand Down